M1 support #41

jizoquval · 2021-09-02T13:53:52Z

Attention

This repo is not maintained anymore. Please use @luca992 fork.

Changed

new arm simulator targets: macosArm64, iosSimulatorArm64, watchosSimulatorArm64, tvosSimulatorArm64
kotlin version to 1.6.20
gradle 7.4.2

Fixed

desktop (arm64, x64, and x86) binaries need to be packed in a fat framworks building XCFramworks (Thanks to @luca992)

netroy · 2021-10-19T19:04:37Z

@ge-org can we please have this merged and released?
it would unblock a bunch of us who want to start either building KMP for arm64, or simply want debug symbols when debugging an iOS app on a device (instead of of the simulator). I suppose it'd also unblock people who want to debug on the simulator on an M1 mac.

dstranz · 2021-10-21T13:23:16Z

Hello @jizoquval, thank you for you work. I'm testing your change but it doesn't seem to work with my project.

I have following configuration:

multiplatformSwiftPackage {
    packageName("MyProject")
    swiftToolsVersion("5.3")
    buildConfiguration { release() }
    targetPlatforms {
        iOS { v("13") }
    }
    outputDirectory(File(projectDir, "build/xcframework"))
}

And then run:

./gradlew :MyProject:createXCFramework

But created XCFramework doesn't have arm64-simulator architecture.

ls MyProject/build/xcframework/MyProject.xcframework
Info.plist           ios-arm64            ios-x86_64-simulator

I'm using Kotlin 1.5.30 and Gradle 7.2.

batuypn · 2021-10-22T09:04:34Z

Hi @dstranz, I think you need to add iosSimulatorArm64() target in your build.gradle like here. But also the dependencies used in the project should have support for arm64 (for example, currently ktor doesnt have).

mqln · 2021-11-09T08:28:55Z

Hello, @ge-org ! Any luck on this? My team needs M1 support, so we're deciding if we should just add it ourselves and fork the repo here.

dstranz · 2021-11-09T08:33:10Z

Hello, @dstranz! Any luck on this? My team needs M1 support, so we're deciding if we should just add it ourselves and fork the repo here.

Hello 👋🏻

I'm also waiting for merging M1 support to released version of this Gradle plugin.

Maybe you should ask project owner about future plans for this task?

netroy · 2021-11-12T13:52:10Z

I managed to get this working by uploading a built jar to our internal maven repo.
But the createXCFramework task now fails with

Both 'ios-arm64-simulator' and 'ios-x86_64-simulator' represent two equivalent library definitions.

I see that this is coming from xcodebuild, and not this plugin. But, does anyone with more xcode experience know if I'm doing anything wrong?

netroy · 2021-11-12T13:59:14Z

I also noticed that iosArm64 and iosX64 builds in the build folder contain both a debugFramework as well as a releaseFramework. But, iosSimulatorArm64 only has a releaseFramework.

this is how I've enabled ios builds in my gradle file:

kotlin {
  ....
  listOf(
    iosX64(),
    iosArm64(),
    iosSimulatorArm64()
  ).forEach {
    it.binaries.framework {
      ....
    }
  }
  ....
}

How can I get the debugFramework for iosSimulatorArm64?
I assume I need that to be able to see compile and debug any app using this xcframework.

dstranz · 2021-11-22T09:13:28Z

I've just see that there is a new JetBrains plugin for creating XCFramework. That maybe a good replacement for this plugin. It Gradle configuration looks like that in new created project:

import org.jetbrains.kotlin.gradle.plugin.mpp.apple.XCFramework

plugins {
    kotlin("multiplatform")
    id("com.android.library")
}

kotlin {
    android()
    
    val xcf = XCFramework()
    listOf(
        iosX64(),
        iosArm64(),
        //iosSimulatorArm64() sure all ios dependencies support this target
    ).forEach {
        it.binaries.framework {
            baseName = "MyLibrary"
            xcf.add(this)
        }
    }

    sourceSets {
        val commonMain by getting
        val commonTest by getting {
            dependencies {
                implementation(kotlin("test-common"))
                implementation(kotlin("test-annotations-common"))
            }
        }
        val androidMain by getting
        val androidTest by getting {
            dependencies {
                implementation(kotlin("test-junit"))
                implementation("junit:junit:4.13.2")
            }
        }
        val iosX64Main by getting
        val iosArm64Main by getting
        //val iosSimulatorArm64Main by getting
        val iosMain by creating {
            dependsOn(commonMain)
            iosX64Main.dependsOn(this)
            iosArm64Main.dependsOn(this)
            //iosSimulatorArm64Main.dependsOn(this)
        }
        val iosX64Test by getting
        val iosArm64Test by getting
        //val iosSimulatorArm64Test by getting
        val iosTest by creating {
            dependsOn(commonTest)
            iosX64Test.dependsOn(this)
            iosArm64Test.dependsOn(this)
            //iosSimulatorArm64Test.dependsOn(this)
        }
    }
}

android {
    compileSdk = 31
    sourceSets["main"].manifest.srcFile("src/androidMain/AndroidManifest.xml")
    defaultConfig {
        minSdk = 21
        targetSdk = 31
    }
}

adamwaite · 2021-12-02T20:24:22Z

Thanks @dstranz. With this new plugin, where is the generated framework after running a ./gradlew build? I see frameworks in bin and fat-framework but no idea which to use.

jizoquval · 2021-12-06T11:56:02Z

@adamwaite Under the build folder you will have fat-framework and XCFrameworks. XCFrameworks/release is exactly what you need.

This is my setup

    val xcf = XCFramework("YourLibName")
    listOf(
        iosX64(),
        iosArm64(),
        iosSimulatorArm64()
    ).forEach { target ->
        target.binaries.framework {
            baseName = "YourLibName"
            xcf.add(this)
        }
    }

    sourceSets {
        val commonMain by getting
        val androidMain by getting
        val androidTest by getting 
        val iosX64Main by getting
        val iosArm64Main by getting
        val iosSimulatorArm64Main by getting
        val iosMain by creating {
            dependsOn(commonMain)
            iosX64Main.dependsOn(this)
            iosArm64Main.dependsOn(this)
            iosSimulatorArm64Main.dependsOn(this)
        }
    }

And you can build it using next gradle command:
./gradlew shared:assembleYourLibNameXCFramework

JohNan · 2022-01-20T10:32:13Z

@ge-org What's stopping from merging this?

luca992 · 2022-04-26T22:46:26Z

Has anyone published the fork of this PR, are they are not maintaining this anymore?

luca992 · 2022-04-27T18:28:40Z

Forked this pr and published it here 👍
settings.gradle:

pluginManagement {
    repositories {
        maven ("https://s01.oss.sonatype.org/content/repositories/releases/")
    }
}

id("io.github.luca992.multiplatform-swiftpackage") version "2.0.3-arm64"

luca992 · 2022-04-28T01:39:22Z

So turns out there's a few issues with this pr.
I'm running into this issue: https://developer.apple.com/forums/thread/666335

Before making an XCFramwork: macos (including simulators) arm64, x64, and x86 binaries need to be packed in a fat framework 🙃

I'm gonna make a pr for your fork to include the fixes @jizoquval

luca992 · 2022-04-29T00:33:44Z

Working build:

pluginManagement {
    repositories {
        maven ("https://s01.oss.sonatype.org/content/repositories/releases/")
    }
}

id("io.github.luca992.multiplatform-swiftpackage") version "2.0.4-arm64"

luca992 · 2022-04-29T04:14:03Z

@jizoquval jizoquval#2 made a PR for your PR 😅

jizoquval · 2022-04-29T19:26:28Z

@luca992 Thanks, I will look at it tomorrow!

…mworks building XCFramworks

Entry META-INF/gradle-plugins/com.chromaticnoise.multiplatform-swiftpackage.properties is a duplicate but no duplicate handling strategy has been set.

markst · 2022-05-05T12:10:15Z

Works great here!:

markst · 2022-05-18T08:25:09Z

src/main/kotlin/com/chromaticnoise/multiplatformswiftpackage/task/CreateXCFrameworkTask.kt

+        if (targets.isNotEmpty()) {
+            val buildType = if (targets[0].linkTask.name.contains("Release")) "release" else "debug"
+            baseName = configuration.packageName.value
+            destinationDir = buildDir.resolve("bin/iosSimulatorUniversal/${buildType}Framework")


is it possible this isn't honouring multiplatformSwiftPackage.outputDirectory?

error: the path does not point to a valid framework: xxxx/build/bin/iosSimulatorUniversal/releaseFramework/xxx.framework

I don't think I touched anything that would affect outputDirectory. The intermediate build binaries stored in bin shouldn't affect outputDirectory?

How did you cause that error?

@luca992 I can provide example gradle file. Version 2.0.3 succeeds. But it seems this fork is generating the intermediate framework with the wrong filename. The output appears to be our manifest package name rather than defined baseName.

Only seems to be the case for iosSimulatorUniversal. Resolution to succeed build is to label baseName the same as our manifest package name. But this means the wrong framework name for imports.

thanks @jizoquval will take a look this week

haven't been able to test changes yet. gave up trying to use checked out version. might it be possible to make another release on your repository @luca992 ?

sure. I'll do that today

@markst try my new build 2.0.5-arm64

Thanks @luca992. @jizoquval those changes seems to have fixed the issue!

jacao · 2022-05-24T14:33:43Z

+1 on this issue

lazar-otasevic-cif · 2022-06-29T14:22:18Z

how can i use this fork since the original one is abandoned?

luca992 · 2022-06-29T14:51:17Z

Created a new release with the latest changes for this pr:

pluginManagement {
    repositories {
        maven ("https://s01.oss.sonatype.org/content/repositories/releases/")
    }
}

id("io.github.luca992.multiplatform-swiftpackage") version "2.0.5-arm64"

markst · 2022-06-29T16:34:31Z

thanks @luca992 . can't seem to use it yet:

Plugin Repositories (could not resolve plugin artifact 'io.github.luca992.multiplatform-swiftpackage:io.github.luca992.multiplatform-swiftpackage.gradle.plugin:2.0.5-arm64')

luca992 · 2022-06-29T16:38:26Z

@markst If you tried immediately it probably wasn't indexed yet. Should be up now I think: https://repo1.maven.org/maven2/io/github/luca992/multiplatform-swiftpackage/io.github.luca992.multiplatform-swiftpackage.gradle.plugin/

luca992 · 2022-06-29T16:39:10Z

Yeah. Gradle resolved it for me. Just tried

lazar-otasevic-cif · 2022-06-30T08:38:00Z

its working! thanks

Nebneb · 2022-08-31T12:00:23Z

Hi there, any news on this PR?

I do experiment this issue and the fix @luca992 provided is working fine on my side, but it is still a little bit hacky to use a fork for this fix instead of an approved release.

luca992 · 2022-08-31T14:08:54Z

Hi there, any news on this PR?

I do experiment this issue and the fix @luca992 provided is working fine on my side, but it is still a little bit hacky to use a fork for this fix instead of an approved release.

Idk not up to me 🤷‍♂️.

Ps. The macos fat framework workaround can now be removed on kotlin 1.8 dev builds and be ported over to how the fat frameworks are being generated for the other targets.
https://youtrack.jetbrains.com/issue/KT-47355/Support-macos-target-for-FatFramework-task

muellnes · 2022-10-01T08:56:00Z

@luca992 changes are working also fine on my side. So what is still the issue with integrating the changes?
Does someone need to make the Travis CI job happy?

luca992 · 2022-11-16T19:40:32Z

Kotlin 1.8.0-beta is out. That macOs fat framework workaround now could probably be removed now to match all the other targets.

luca992 · 2023-01-09T18:16:33Z

They clearly aren't maintaining this. I updated my fork with a new release using kotlin 1.8.0 that removes my hacky macOs fat framework workaround. I don't see the point in submitting more pr updates here until someone responds, and I will just maintain my own fork 🙃.

// build.gradle.kts
plugins {
  // projects targting kotlin >=1.8.0
  id("io.github.luca992.multiplatform-swiftpackage") version "2.1.4"
  // projects targting kotlin <1.8.0
  id("io.github.luca992.multiplatform-swiftpackage") version "2.0.5-arm64"
}

LukeSmith16 · 2023-02-26T05:12:55Z

Hey @luca992 - Just playing around with your fork on a new project. After running gradlew createSwiftPackage and then fetching the package remotely in my xcode project i'm getting this error:
Missing path (/Users/.../Library/Developer/Xcode/DerivedData/project/SourcePackages/checkouts/kmmtest/shared.xcframework/ios-arm64_x86_64-simulator/dSYMs) from XCFramework 'shared.xcframework' as defined by 'DebugSymbolsPath' in its Info.plist file

I'm not sure if this directly relates to your fork.

But here's the project .

luca992 · 2023-02-26T05:20:09Z

@LukeSmith16 yeah idk off hand. I'll take a look.

One thing to note... Sometimes I have to run createSwiftPackage twice, as the first run sometimes doesn't generate all the files. I'm not sure why exactly, or even if my fork's changes are to blame. I haven't had time to look into it yet. Maybe try that, and see if that helps?

LukeSmith16 · 2023-02-26T11:16:11Z

@luca992 Thanks for the reply! Yeah so if i drag the package locally into xcode it works fine. It's just when i fetch it remotely it can't locate the dsyms. I thought this could have been .gitignore not including the dsym files, but it's not 😢 - I will keep trying to figure out why this isn't working for me but maybe i think it's not related to your fork as it's working locally fine.

luca992 · 2023-02-26T14:17:50Z

@LukeSmith16 you didn't check-in the files in the dsyms folders.

My project for reference:
https://github.com/eqoty-labs/secretk

LukeSmith16 · 2023-02-28T08:54:45Z

@luca992 Yeah i'm having to check those dsym files in manually at the moment. I don't know why GIT isn't picking them up 🤔 - But yeah i got it working after manually checking them in, thanks for the help 👍

SamvelDev · 2023-06-08T07:41:08Z

Hey dear, I still don't understand if this problem is solved or not, I still have a problem (((
please help me @jizoquval @

luca992 · 2023-06-08T15:37:12Z

Hey dear, I still don't understand if this problem is solved or not, I still have a problem ((( please help me @jizoquval @

should be working with my fork:
#41 (comment)

Val added 3 commits September 1, 2021 10:58

Specify kotlin version 1.5.30

113fb3b

Support arm simulator targets

9b8c919

Add tests for arm simulator targets

315300c

jizoquval mentioned this pull request Sep 2, 2021

Create XCFramework for arm simulator #31

Open

glureau mentioned this pull request Sep 7, 2021

M1 support glureau/multiplatform-swiftpackage#1

Merged

ameriod mentioned this pull request Oct 2, 2021

M1 support ameriod/multiplatform-swiftpackage#1

Open

lyndseypenman approved these changes Nov 10, 2021

View reviewed changes

wesleydonk mentioned this pull request Jan 17, 2022

Adopting XCFramework of new kotlin version #42

Open

luca992 added 5 commits May 1, 2022 14:59

desktop (arm64, x64, and x86) binaries need to be packed in a fat fra…

00b2b6f

…mworks building XCFramworks

Duplicate workaround gradle/gradle#17236

cd63a7f

Entry META-INF/gradle-plugins/com.chromaticnoise.multiplatform-swiftpackage.properties is a duplicate but no duplicate handling strategy has been set.

use mapNotNull

dbf3d5c

format code

ab93bed

set baseName

e251a09

markst reviewed May 18, 2022

View reviewed changes

Set name of Universal framework same as baseName configurated binaries

c447734

petarmarijanovicfive mentioned this pull request Oct 24, 2022

No support for IosSimulatorArm64 TM-Apps/konnection#1

Closed

luca992 mentioned this pull request Jan 9, 2023

Build failing: symbol(s) not found for architecture arm64 #46

Open

indyfromoz mentioned this pull request Oct 27, 2023

Generate arm64 swift package #53

Open

M1 support #41

Are you sure you want to change the base?

M1 support #41

Conversation

jizoquval commented Sep 2, 2021 • edited

Attention

Changed

Fixed

netroy commented Oct 19, 2021

dstranz commented Oct 21, 2021 • edited

batuypn commented Oct 22, 2021

mqln commented Nov 9, 2021 • edited

dstranz commented Nov 9, 2021

netroy commented Nov 12, 2021

netroy commented Nov 12, 2021

dstranz commented Nov 22, 2021 • edited

adamwaite commented Dec 2, 2021 • edited

jizoquval commented Dec 6, 2021

JohNan commented Jan 20, 2022

luca992 commented Apr 26, 2022 • edited

luca992 commented Apr 27, 2022 • edited

luca992 commented Apr 28, 2022 • edited

luca992 commented Apr 29, 2022 • edited

luca992 commented Apr 29, 2022

jizoquval commented Apr 29, 2022

markst commented May 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jacao commented May 24, 2022

lazar-otasevic-cif commented Jun 29, 2022

luca992 commented Jun 29, 2022

markst commented Jun 29, 2022 • edited

luca992 commented Jun 29, 2022 • edited

luca992 commented Jun 29, 2022 • edited

lazar-otasevic-cif commented Jun 30, 2022

Nebneb commented Aug 31, 2022

luca992 commented Aug 31, 2022 • edited

muellnes commented Oct 1, 2022

luca992 commented Nov 16, 2022 • edited

luca992 commented Jan 9, 2023 • edited

LukeSmith16 commented Feb 26, 2023

luca992 commented Feb 26, 2023 • edited

LukeSmith16 commented Feb 26, 2023

luca992 commented Feb 26, 2023 • edited

LukeSmith16 commented Feb 28, 2023

SamvelDev commented Jun 8, 2023

luca992 commented Jun 8, 2023

jizoquval commented Sep 2, 2021 •

edited

dstranz commented Oct 21, 2021 •

edited

mqln commented Nov 9, 2021 •

edited

dstranz commented Nov 22, 2021 •

edited

adamwaite commented Dec 2, 2021 •

edited

luca992 commented Apr 26, 2022 •

edited

luca992 commented Apr 27, 2022 •

edited

luca992 commented Apr 28, 2022 •

edited

luca992 commented Apr 29, 2022 •

edited

markst commented Jun 29, 2022 •

edited

luca992 commented Jun 29, 2022 •

edited

luca992 commented Jun 29, 2022 •

edited

luca992 commented Aug 31, 2022 •

edited

luca992 commented Nov 16, 2022 •

edited

luca992 commented Jan 9, 2023 •

edited

luca992 commented Feb 26, 2023 •

edited

luca992 commented Feb 26, 2023 •

edited