Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting a an odd CR+LF from website crashes Geany (possibly from an odd encoding) #1036

Open
Poikilos opened this issue Nov 20, 2020 · 6 comments

Comments

@Poikilos
Copy link

  • Geany 1.36
  • en_US.UTF-8
  • GTK 3.24.23
  • GLib 2.64.6

Copying and pasting these four characters crashes Geany 1.36 consistently:
image

  • Opening the file doesn't crash Geany, but pasting it does.

Steps to reproduce issue

  1. Copy from Original source: Mailing address at bottom of https://videocityinc.com/edit/
    • optional: Paste into a new text file in nano to reproduce issue later (copy from there instead of step 1)
      • copy the whole thing from nano or copy just the 4 characters (using GHex)
  2. Paste it into any open text file in Geany.
@b4n
Copy link
Member

b4n commented Nov 20, 2020

I can't reproduce in 1.37/current master. What you have is zero-width-space (U+200B) followed by a newline (U+0A). Nothing too weird here, and nothing that I would expect Geany to crash on.

@Poikilos do you have any plugins enabled? In any case, could you try with a clean configuration to see if you still reproduce (you can use geany -c /tmp/temp-conf)?

FWIW, here's the bytes:

(yes, not much to see, but it's there)

@Poikilos
Copy link
Author

geany -c /tmp/temp-conf

Yep, no crash. On my first try I found that which plugin to disable

  • regular mode: prevent crash by disabling: spell check
    • also I have: Addons, File Browser, Save Actions
    • if I have spell check disabled, then restart, no crash; enable it, paste, instant crash
  • using temp-conf: doesn't crash if spell check is enabled (or even if all of the above are enabled too)

My plugins are from Fedora 32:

$ dnf list installed | grep geany
geany.x86_64                                      1.36-3.fc32                            @updates                                       
geany-libgeany.x86_64                             1.36-3.fc32                            @updates                                       
geany-plugins-addons.x86_64                       1.36-4.fc32                            @updates                                       
geany-plugins-common.x86_64                       1.36-4.fc32                            @updates                                       
geany-plugins-spellcheck.x86_64                   1.36-4.fc32                            @updates

How could it not crash with the temp config even if I enable everything?

@b4n b4n transferred this issue from geany/geany Nov 20, 2020
@b4n
Copy link
Member

b4n commented Nov 20, 2020

Weird indeed… may be the same as #1022?

@b4n
Copy link
Member

b4n commented Nov 20, 2020

…or maybe there's a specific spellcheck configuration option that triggers a crash maybe?

@Poikilos
Copy link
Author

…or maybe there's a specific spellcheck configuration option that triggers a crash maybe?

Correct! I enable "Check spelling while typing" and then it crashes when I paste, even with a temp config. That makes sense.

@codebrainz
Copy link
Member

Weird indeed… may be the same as #1022?

Was my first thought too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants