Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbered Bookmarks - Saving bookmarks, in separate files, also writes to settings.conf #1219

Open
neoh4x0r opened this issue Jan 21, 2023 · 0 comments

Comments

@neoh4x0r
Copy link

In the SaveSettings function (lines 488 to 495) -- if the file details are stored in separate files it will also be written to settings.conf --

while(fdTemp!=NULL)
{
/* if this entry has data needing saveing then save it and increment the counter */
if(SaveIndividualSetting(config,fdTemp,i,fdTemp->pcFileName))
i++;
fdTemp=fdTemp->NextNode;
}

Unless this is, by-design, I think that the following change to the while loop will make it so that the bookmarks are only stored in settings.conf if separate files are not being used

488    while( (fdTemp!=NULL) && (WhereToSaveFileDetails==0) )
489    {
           [...]
495    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant