Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiterm plugin has no translation strings #247

Closed
scriptum opened this issue Jun 25, 2015 · 4 comments
Closed

multiterm plugin has no translation strings #247

scriptum opened this issue Jun 25, 2015 · 4 comments

Comments

@scriptum
Copy link
Member

Please add them

@codebrainz
Copy link
Member

Should probably rename this "Mutliterm plugin has no strings" :)

I think literally the only string is the description of the plugin passed to plugin_set_info(). I'm not sure if the _ function-like macro is available from Vala or whether adding a generated C file to POTFILES.in would cause any grief.

@scriptum
Copy link
Member Author

At least plugin description - thin is the one untranslated.

@b4n
Copy link
Member

b4n commented Jun 25, 2015

@codebrainz I just started to try and see how it would work, and apparently at least recent versions of xgettext have Vala support, so it'll work. I'll open a PR soon

@b4n
Copy link
Member

b4n commented Jun 25, 2015

I think literally the only string is the description of the plugin passed to plugin_set_info().

It has, in a popup menu (and warnings, though those might not need translations as they are only logged on the messages, not really in the UI).

I'm not sure if the _ function-like macro is available from Vala

It is :)

or whether adding a generated C file to POTFILES.in would cause any grief.

It would, as updating the translations require all the files containing translations to be available. Using a C file generated from Vala would mean having build MultiTerm is a requirement to update translations -- and that's probably not really acceptable.
That's the same reason why I have webhelper/src/gwh-enum-types.c under version control, although it shouldn't be as it's a generated file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants