Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./waf updatepo doesn't work #293

Closed
peter-scholtens opened this issue Nov 4, 2015 · 3 comments
Closed

./waf updatepo doesn't work #293

peter-scholtens opened this issue Nov 4, 2015 · 3 comments

Comments

@peter-scholtens
Copy link
Contributor

For some reason the ./waf updatepo script doesn't work. It complains output missing a file. The reason seems to be that (recently?) the files in multiterm are changed from .c to .vala. Simply faking the system by setting a symbolic link for each .c file in this ./multiterm/src directory let the waf script run correctly, like:

ln -s ./multiterm/src/config.vala ./multiterm/src/config.c

But that's a workaround, not a permanent solution, I think.

@frlan
Copy link
Member

frlan commented Nov 4, 2015

This is caused by the fact that the c files are created from the vala files. This should be solved by running ./waf build before doing ./waf updatepo (and having valac installed)

@frlan frlan closed this as completed Nov 4, 2015
@eht16
Copy link
Member

eht16 commented Nov 4, 2015

Nope, this is not enough. The problem is that the generated C sources are expected in the ../multiterm/src folder, relative to the POTFILES.in file.
This is not true when building with Waf because Waf puts the generated C files into _build_/multiterm/src.

I guess with some magic, we could fix this or work around it in some way. But since we plan to drop Waf support after the 1.26 release, I'm tempted to leave this as is for now.
I'm pretty much sure your workaround should suffice for now as the generated C files should contain the same strings as the .vala files.

@eht16 eht16 reopened this Nov 4, 2015
@peter-scholtens
Copy link
Contributor Author

Entering the ./multiterm/src and running make before waf updatepo does the trick too. Indeed, if waf get replaced, don't spend time on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants