Skip to content

Commit

Permalink
Mark the goto popup label as translatable for localized colons
Browse files Browse the repository at this point in the history
It could arguably not be translatable and only `filename:line` display,
but as we have already a space on the right of the colon it's not, and
allowing translation is not a problem and can give better localization.
  • Loading branch information
b4n committed Feb 28, 2016
1 parent b46e183 commit 8b61b9f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/symbols.c
Expand Up @@ -1979,9 +1979,11 @@ static void show_goto_popup(GeanyDocument *doc, GPtrArray *tags, gboolean have_b
gchar *text;

if (! first && have_best)
text = g_markup_printf_escaped("<b>%s: %lu</b>", fname, tmtag->line);
/* For translators: it's the filename and line number of a tag in the goto-tag popup menu */

This comment has been minimized.

Copy link
@techee

techee Mar 1, 2016

Member

@b4n Would probably be better to replace "tag" with "symbol" here as this is what the translators will see now.

This comment has been minimized.

Copy link
@b4n

b4n Mar 1, 2016

Author Member

good point. fixed in 6ba26cf thanks!

This comment has been minimized.

Copy link
@techee

techee Mar 1, 2016

Member

Great :)

text = g_markup_printf_escaped(_("<b>%s: %lu</b>"), fname, tmtag->line);
else
text = g_markup_printf_escaped("%s: %lu", fname, tmtag->line);
/* For translators: it's the filename and line number of a tag in the goto-tag popup menu */

This comment has been minimized.

Copy link
@techee

techee Mar 1, 2016

Member

Same here.

text = g_markup_printf_escaped(_("%s: %lu"), fname, tmtag->line);

image = gtk_image_new_from_pixbuf(symbols_icons[get_tag_class(tmtag)].pixbuf);
label = g_object_new(GTK_TYPE_LABEL, "label", text, "use-markup", TRUE, "xalign", 0.0, NULL);
Expand Down

0 comments on commit 8b61b9f

Please sign in to comment.