Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: No syntax highlighting for bash lists with one item #1308

Closed
radioactiveman opened this issue Nov 18, 2016 · 8 comments
Closed
Milestone

Comments

@radioactiveman
Copy link
Contributor

radioactiveman commented Nov 18, 2016

Bash lists with only one string item are not applying syntax highlighting.
It worked correctly with an older version of Geany, but I cannot say when this regression was introduced.

Example:

#!/bin/bash

var1=('foo')
var2=('foo: works')
var3=('foo', 'bar')

Expected syntax highlighting:
https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/audacious
See line 13, 16-20, 22.

System information:

  • Arch Linux
  • Geany 1.29
@radioactiveman
Copy link
Contributor Author

radioactiveman commented May 4, 2017

The issue persists with version 1.30.1.

@elextr
Copy link
Member

elextr commented May 4, 2017

Highlighting is provided by the editing widget Geany uses from the Scintilla project. Please report the issue there.

Though I am not sure its a bug, being assigned to a variable, it can also correctly be considered an expression in parens not a command list as I read the bash manual, so it should not be list highlighted.

@radioactiveman
Copy link
Contributor Author

Thank you, reported as https://sourceforge.net/p/scintilla/bugs/1944/. Feel free to close this issue.

@elextr
Copy link
Member

elextr commented May 4, 2017

Thanks for reporting back the Scintilla issue, we normally leave issues open until we see what Scintilla does.

@radioactiveman
Copy link
Contributor Author

Fixed upstream: https://sourceforge.net/p/scintilla/code/ci/7619719dd43233dbf9f440cfbf5e4d4a48fe552d/

Do you plan to update Scintilla with the next release?

@elextr
Copy link
Member

elextr commented May 8, 2017

If there is a Scintilla release in time it should be included.

@radioactiveman
Copy link
Contributor Author

Version 3.7.5 of Scintilla has been released now.

@elextr
Copy link
Member

elextr commented May 27, 2017

Yes, when someone has time to import the new version it will be added to Geany.

b4n added a commit to b4n/geany that referenced this issue May 30, 2017
This now requires a C++11-capable compiler.

Closes geany#1308.
@b4n b4n added this to the 1.32 milestone Jul 21, 2017
elextr pushed a commit that referenced this issue Jul 24, 2017
* Update Scintilla to version 3.7.5

This now requires a C++11-capable compiler.

Closes #1308.

* Test using newer dist on Travis

Since Scintilla needs C++11

* Add debugging code for when configure fails

* Workaround a pkg-config-corsswrapper bug on Ubuntu 14.04

See https://bugs.launchpad.net/ubuntu/+source/mingw-w64/+bug/1327242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants