Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to the goto symbol popup #1398

Open
vfaronov opened this issue Feb 15, 2017 · 3 comments
Open

Add more info to the goto symbol popup #1398

vfaronov opened this issue Feb 15, 2017 · 3 comments

Comments

@vfaronov
Copy link
Contributor

To expand on #950 and #1069...

As a Python programmer, I find that the goto symbol popup is considerably more useful to me with a change like this:

-			text = g_markup_printf_escaped(_("%s: %lu"), fname, tmtag->line);
+			text = g_markup_printf_escaped(
+				_("%s\n<small>%s: %lu</small>"),
+				tmtag->scope, fname, tmtag->line);

because then I can immediately see the name of the class containing the tag, which is useful when I have 10 different classes with an execute method in each of them.

But this doesn’t work in many other cases (even in Python).

Then of course, TMTag has a bunch of other fields that might also be very useful.

Maybe there’s a way to put this information to good use without breaking the current use cases? Maybe a preference?

@elextr
Copy link
Member

elextr commented Feb 15, 2017

The idea sounds useful, for languages that don't have to put every class in its own file. My current project has parse() in each of ten classes.

Maybe replace the filename with the scope otherwise where the scope is a nested thing (eg my_namespace::my_sub_namespace::my_class::my_nested_class) the popup may get a bit big.

Or have preferences that allow the user to choose one or both and can then the list be expanded to add any other potential disambiguating information.

@kugel-
Copy link
Member

kugel- commented Feb 21, 2017

+1 the file path is truly needed, I often have multiple copies of the same file open (having to work with svn).

@vfaronov
Copy link
Contributor Author

The path could also be given relative to the project’s root, if it’s under that root.

vfaronov added a commit to vfaronov/geany that referenced this issue Apr 18, 2017
vfaronov added a commit to vfaronov/geany that referenced this issue Apr 25, 2017
vfaronov added a commit to vfaronov/geany that referenced this issue May 28, 2017
vfaronov added a commit to vfaronov/geany that referenced this issue Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants