Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared search for values on 'Find' / 'Replace' / 'Find in files' #2320

Open
chrisgraham opened this issue Sep 24, 2019 · 1 comment
Open

Comments

@chrisgraham
Copy link

chrisgraham commented Sep 24, 2019

I think all these 3 dialogs should share the same 'search for' value and history.

For example, if I do a search for 'foo' and then decide I want to do a replace of 'foo' with 'bar', it would be good if the replace dialog had 'foo' in there already.
(I realize if I leave the last search result highlighted it would, but I may not do so)

This issue may relate to the implementation of #1666.

@elextr
Copy link
Member

elextr commented Sep 24, 2019

Probably needs internal implementation of FIF since its options are wildly differing, but also there are differing options on find and the findy part of replace that would need resolving to ensure you get the same result for a common search pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants