stash_group_add_string() doesn't handle default value anymore

[eht16]

Since some time, stash_group_add_string() does not set the passed default value to the setting any longer if the setting is not found.

This might be related to cf77c8c.

There is a real implication of this:
I noticed crashing Geany when the VTE setting follow_path is true and send_cmd_prefix is not set. This results in vc->send_cmd_prefix being NULL which then leads to crashes when commands are to be executed in the VTE (it should not crash even then, a fix for the VTE issue will follow).

But the root cause here is that it seems that the passed default stash_group_add_string() is ignored.

@kugel-, could you maybe have a look?

[eht16]

Just noticed, even if send_cmd_prefix is set in the config, its value is not read properly and vc->send_cmd_prefix remains NULL.

[kugel-]

So you you think stash_group_add_string is buggy or this issue is only with the send_cmd_prefix pref?

In #3151 the commit be739e2 was identified as first buggy commit, but that doesn't change stash_group_add_string as far as I can tell.

[elextr]

See possible patch posted to #3151

[eht16]

So you you think stash_group_add_string is buggy

This was my first guess but it seems wrong.

In #3151 the commit be739e2 was identified as first buggy commit, but that doesn't change stash_group_add_string as far as I can tell.

Yeah, be739e2 is more relevant and the patch in #3151 fixes reading the VTE settings for me.

[eht16]

Closing this one in favor of #3151.