New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTE: Fix crash when "send_cmd_prefix" is NULL #3153
Conversation
fc825cb
to
ec9cd86
Compare
Obsoleted by #3156 (IMO) |
Having this patch active I didn't see further crashes hitting e.g. f5 most likely caused by in thix context unset send_cmd_prefix |
Not necessarily I'd say. |
But we aren't going to augment every pref in case garbage is read from geany.conf, do we? |
No, of course not. |
I'm not blocking, go ahead if you think it's worthwhile |
ec9cd86
to
af7582d
Compare
Just fixed the merge conflict. If there are no objections, let's merge it. |
LGTM |
Related to #3151 and #3149.
The
NULL
check invte_send_cmd()
is just for feeling more safe, the main change is to considervc->send_cmd_prefix
beingNULL
when constructing the command to be executed when we want to change the directory in the VTE.This should not happen but it might.