Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session lost when upgrading from 1.38 #3236

Closed
b4n opened this issue Jul 17, 2022 · 3 comments · Fixed by #3264
Closed

Session lost when upgrading from 1.38 #3236

b4n opened this issue Jul 17, 2022 · 3 comments · Fixed by #3264
Milestone

Comments

@b4n
Copy link
Member

b4n commented Jul 17, 2022

I just pulled and built master, and installed it over my previous (olde…) 1.38 (git >= 75d3c9f12) (my head was actually at 11a1f32, not 100% sure what was really installed, but it ough to be very close to 1.38).

Anyway, when restarting Geany, it didn't restore any file from my session. I see No user session file found, trying to use configuration file. but nothing gets loaded then, although my geany.conf does 120 FILE_NAME_%d entries.

I didn't investigate yet and unfortunately don't have time to right now, but I guess it has to do with session-split not properly falling back somehow.

@eht16
Copy link
Member

eht16 commented Jul 17, 2022

Yeah, I had similar problems with the list of active plugins (#3183 (comment)).

@kugel- promised to provide some sort of migrtion before releasing. I added a corresponding TODO in the project https://github.com/geany/geany/projects/4.

@kugel-
Copy link
Member

kugel- commented Jul 17, 2022

@b4n's case should work, there seems to be a bug.

But generally, the current planning is to have a one-time migration if session.conf doesn't exist yet to cover upgrading from 1.38 to the next release (i.e. read all "session prefs" from geany.conf as if it were session.conf). After that, if session.conf already exists, no further migration is planned. I.e. if you track GIT master.

kugel- added a commit to kugel-/geany that referenced this issue Aug 27, 2022
The fallback was not applied for loading the user session files (i.e.
the opened files) but only for other session config.

Fixes geany#3236
@kugel-
Copy link
Member

kugel- commented Aug 27, 2022

@b4n I looked into this and created a fix, see #3264

kugel- added a commit that referenced this issue Sep 8, 2022
The fallback was not applied for loading the user session files (i.e.
the opened files) but only for other session config.

Fixes #3236
@b4n b4n added this to the 1.39/2.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants