Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar does nothing after moving it #3831

Closed
ntrel opened this issue Apr 12, 2024 · 1 comment · Fixed by #3838
Closed

Search bar does nothing after moving it #3831

ntrel opened this issue Apr 12, 2024 · 1 comment · Fixed by #3838
Labels
bug confirmed A developer reproduced this issue, or it affetcs enough users
Milestone

Comments

@ntrel
Copy link
Member

ntrel commented Apr 12, 2024

After moving the search bar in the Customize Toolbar dialog, it will no longer do anything when typing in the entry. Possibly related to this code:

static void geany_entry_action_connect_proxy(GtkAction *action, GtkWidget *widget)
{
	GeanyEntryActionPrivate *priv = GEANY_ENTRY_ACTION_GET_PRIVATE(action);

	/* make sure not to connect handlers twice */
	if (! priv->connected)
		if (priv->numeric)
			g_signal_connect(priv->entry, "insert-text",
				G_CALLBACK(ui_editable_insert_text_callback), NULL);
		g_signal_connect(priv->entry, "changed", G_CALLBACK(delegate_entry_changed_cb), action);
		g_signal_connect(priv->entry, "activate", G_CALLBACK(delegate_entry_activate_cb), action);
		g_signal_connect(priv->entry, "activate-backward",
			G_CALLBACK(delegate_entry_activate_backward_cb), action);

		priv->connected = TRUE;
	}
@ntrel ntrel added the bug label Apr 12, 2024
@b4n b4n added the confirmed A developer reproduced this issue, or it affetcs enough users label Apr 13, 2024
b4n added a commit to b4n/geany that referenced this issue Apr 13, 2024
According to b0b0ebb we guard against
proxying the widget more than once for some Windows reasons, but this
breaks the case where the same GeanyEntryAction has to re-create a
fresh proxy, like when moving the item around.

So, move the guard value to the proxied widget, not the action.

Fixes geany#3831.
@b4n
Copy link
Member

b4n commented Apr 14, 2024

yay for a 12-years old issue :) b0b0ebb

@b4n b4n closed this as completed in #3838 Apr 18, 2024
@b4n b4n added this to the 2.1 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed A developer reproduced this issue, or it affetcs enough users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants