Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation stockade in "Send to Custom Command ..." #953

Open
scriptum opened this issue Mar 9, 2016 · 3 comments · May be fixed by #1058
Open

Translation stockade in "Send to Custom Command ..." #953

scriptum opened this issue Mar 9, 2016 · 3 comments · May be fixed by #1058
Labels
i18n Internationalization (translations, localization, …)

Comments

@scriptum
Copy link
Member

scriptum commented Mar 9, 2016

This looks wierd:


#: ../src/keybindings.c:474
msgid "Send to Custom Command 1"
msgstr "Передать пользовательской команде 1"

#: ../src/keybindings.c:476
msgid "Send to Custom Command 2"
msgstr "Передать пользовательской команде 2"

#: ../src/keybindings.c:478
msgid "Send to Custom Command 3"
msgstr "Передать пользовательской команде 3"

#: ../src/keybindings.c:480
msgid "Send to Custom Command 4"
msgstr "Передать пользовательской команде 4"

#: ../src/keybindings.c:482
msgid "Send to Custom Command 5"
msgstr "Передать пользовательской команде 5"

#: ../src/keybindings.c:484
msgid "Send to Custom Command 6"
msgstr "Передать пользовательской команде 6"

#: ../src/keybindings.c:486
msgid "Send to Custom Command 7"
msgstr "Передать пользовательской команде 7"

#: ../src/keybindings.c:488
msgid "Send to Custom Command 8"
msgstr "Передать пользовательской команде 8"

#: ../src/keybindings.c:490
msgid "Send to Custom Command 9"
msgstr "Передать пользовательской команде 9"

Could you collapse this into "Send to Custom Command %d"?
@b4n
Copy link
Member

b4n commented Mar 9, 2016

Would make sense indeed

@b4n b4n added this to the 1.28 milestone Mar 9, 2016
@b4n b4n added the i18n Internationalization (translations, localization, …) label Mar 9, 2016
b4n added a commit to b4n/geany that referenced this issue Jun 8, 2016
@b4n
Use a format string instead of repeating almost the same string 9 times
c866070 
This simplifies translations by being less redundant.

Note: label variable is not freed because `keybindings_set_item()`
currently assumes static strings but for plugins, so we need not free
the label right away.  It's not a real problem though, as this string
is required during the whole process' lifetime, so it'd use just as
much memory anyway.

Closes geany#953.
@b4n
Copy link
Member

b4n commented Jun 8, 2016

Hum, actually it's kinda annoying to fix because we have a hack that requires static strings as the label. This should be fixed in order to be able to do fix that properly.

@b4n b4n linked a pull request Jun 8, 2016 that will close this issue
Open
@b4n b4n removed this from the 1.28 milestone Jul 8, 2016
@b4n
Copy link
Member

b4n commented Jul 8, 2016

BTW, while this indeed seem suboptimal, translations now contain this so it's less of a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i18n Internationalization (translations, localization, …)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a format string instead of repeating almost the same string 9 times b4n/geany
2 participants
@scriptum @b4n