Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1138] Added 'Rename' option to right-click menu for Documents tab #1140

Closed
wants to merge 1 commit into from
Closed

Conversation

Fordi
Copy link

@Fordi Fordi commented Jul 14, 2016

No description provided.

@@ -1273,7 +1273,6 @@ void document_show_tab(GeanyDocument *doc)
document_get_notebook_page(doc));
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't remove this line (it's part of the style -- and in any case, don't introduce style-only changes in the middle of a commit)

@b4n
Copy link
Member

b4n commented Jul 14, 2016

Although I made a lot of comments, it looks mostly fine.

@Fordi
Copy link
Author

Fordi commented Jul 14, 2016

This was just a spike with reference to the ticket (#1138) to provide a quick implementation; I didn't vet it fully; the impl was to add it for my local machine, and I floated it just to see if you guys would want it for 1138.

Initially the idea was to shove an in-place Rename text box in the Documents list when you click rename - that's why the edit is a bit more complex / inconsistent than it needs to be - but when I noticed you could do it from the Save As... dialog, I went the lazy route (I had non-voluntary work to get finished) instead.

Anyway, I'll close the PR if y'all don't want it.

@b4n
Copy link
Member

b4n commented Jul 14, 2016

No, it makes sense to have it next to Save if people want it, so after a few fixes this PR would be fine.

@kugel-
Copy link
Member

kugel- commented Mar 29, 2017

It doesn't look like the requested changes will be made. I suggest closing this.

@Fordi are you planning to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants