Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: Fix the tooltip to mention PCRE, not POSIX regular expressions #1168

Merged
merged 1 commit into from Aug 9, 2016
Merged

search: Fix the tooltip to mention PCRE, not POSIX regular expressions #1168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/search.c
View file
Open in desktop
Expand Up @@ -308,7 +308,7 @@ static GtkWidget *add_find_checkboxes(GtkDialog *dialog)
check_regexp = gtk_check_button_new_with_mnemonic(_("_Use regular expressions"));
ui_hookup_widget(dialog, check_regexp, "check_regexp");
gtk_button_set_focus_on_click(GTK_BUTTON(check_regexp), FALSE);
gtk_widget_set_tooltip_text(check_regexp, _("Use POSIX-like regular expressions. "
gtk_widget_set_tooltip_text(check_regexp, _("Use PCRE regular expressions. "
"For detailed information about using regular expressions, please read the documentation."));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "documentation" do you mean the Geany manual or the PCRE documentation, its not clear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mean anything, it's not changed in the patch.

However, I guess it refers to the manual, which points to GLib's PCRE docs. At least it's how I'd understand it.

Copy link
Member

@elextr elextr Aug 8, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mean anything, it's not changed in the patch.

Damn github showing context so people find other things to change ;-D

Suggest s/documentation/Geany manual/ then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest s/documentation/Geany manual/ then.

I don't think it's useful, because I couldn't imagine what other people would imagine this refers to. It's a message inside Geany, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but we could also add a Help button to that dialog opening teh manual at the right place BTW. unrelated but could be nice)

Copy link
Member

@elextr elextr Aug 8, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's useful, because I couldn't imagine what other people would imagine this refers to. It's a message inside Geany, isn't it?

I did, it mentions PCRE then says "see the documentation" so obviously it is referring to PCRE docs.

[Edit: so I was gonna ask for a reference to such docs]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't see it that way and find it kinda far-fetched, but please, PR welcome :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1170

g_signal_connect(check_regexp, "toggled",
G_CALLBACK(on_find_replace_checkbutton_toggled), dialog);
Expand Down