Escape format arguments passed to ui_label_set_markup() #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An additional change could be to deprecate those UI functions for future privatisation, recommending callers to instead use GTK+ directly. This bug is a good case for doing so :) |
|
Indeed, especially as there's no internal use of this function, and the only plugin I know using this is WebHelper which could easily do it on its own. |
|
LGBI Subtle bug. For the API, its not documented as supporting markup, so this is a bugfix for an undocumented capability that leaked. |
It has no usage inside Geany itself, had a bug in handling of markup in the label, has only one user in Geany-Plugins, and is fairly easy to reproduce.
|
@codebrainz @elextr added a commit to deprecate |
|
Still LGBI |
b4n
added a commit
that referenced
this pull request
Aug 20, 2016
Escape format arguments passed to ui_label_set_markup(), and deprecate ui_frame_new_with_alignment() which exposed a broken API because of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good example of why is the changes to
ui_menu_add_document_items_sorted(): the format should contain markup, but the placeholders should not (they will generally be mostly unknown text).This however has one side effect on the API:
ui_frame_new_with_alignment()'s first argument is passed as-is toui_label_new_bold(), which itself is implemented usingui_label_set_markup(). The documentation ofui_frame_new_with_alignment()never suggested it supported markup (and none of the users I could fine did expect that), but it's a change in how the API works.IMO it's a bug fix (markup control character no longer break frame labels), but someone could see it as a feature removal (although it'd be somewhat dishonest as it never was advertized).