Port more prefs to Stash #1184
Port more prefs to Stash #1184
Conversation
|
Seems like a reasonable first step to get prefs all the using the same API so we can more easily switch them all at once to something more appropriate like GSettings (w/ keyfile backend). Still need to review the code. |
|
LGBCI
Love to help, but I don't know what you are talking about (guess whatever is unnoticed is still unnoticed :) |
The UI for the icon size and style are a little tricky, because they use radio buttons but spread them across two settings: the "system default", and the specific values. To handle this, we give a dummy default to the "system default" in the specific setting, and handle the separate "system default" setting *after* for it to override the radio button choice. This is somewhat tricky, but not worse than what was previously done, where the specific setting wasn't loaded if the "system default" was used, yet it was written (and actually used in the fallback path in case the "system default" is missing), leading to using a potentially random value.
Are left the ones requiring special handling.
|
@elextr what's "C" in "LGBCI"? "Code"? "Careful"?
Heh ^^ /* note: new settings should be added in init_pref_groups() */
static void load_dialog_prefs(GKeyFile *config)
{ |
|
On 21 August 2016 at 00:44, Colomban Wendling notifications@github.com
|
This both reduces the amount of code (by more than ⅔!), and tries to move towards a state where new contributors don't feel like using manual keyfile read/write is the way to go (experience has shown the
load_dialog_prefs()has a way of going unnoticed -- but @elextr will come up with a nice way of documenting this 😉).In theory it also reduce the possibility for typos leading to settings not being saved/loaded properly (i.e. if the setting name/group doesn't match), but as it's currently working it mostly allows for mistakes in the diff of this PR 😄
Though, I should have done that carefully enough to not risk too much. But review is of course a good idea (hint hint).