Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utils_get_real_path() and use it #1224

Closed
wants to merge 2 commits into from
Closed

Add utils_get_real_path() and use it #1224

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8a5212
Add utils_get_real_path() and use it
codebrainz Sep 11, 2016
0370112
Mark tm_get_real_path with G_DEPRECATED_FOR
codebrainz Sep 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/tagmanager/tm_source_file.h
View file
Open in desktop
Expand Up @@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name, const char *name);

void tm_source_file_free(TMSourceFile *source_file);

gchar *tm_get_real_path(const gchar *file_name);
gchar *tm_get_real_path(const gchar *file_name)
#ifndef GEANY_PRIVATE
G_DEPRECATED_FOR(utils_get_real_path)
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, can't we move the implementation at the non-deprecated place and use it in the deprecated one, instead of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean a reverse dependency of TagManager on Geany?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah; now it's under src/ it might not be so bad

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems wrong, which is why I did it like this, but if you'd prefer to have TM also depend on Geany, I can change it to be so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Myeah it wouldn't really be pretty either. I don't care much, you can keep it like it's now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need TM to depend on Geany anyway - while working on #963 I realized I'd need to know in TM if GIO is used for opening/saving files or not.

We actually don't need to create the libtagmanager library - the sources inside "tagmanager" can just be other sources of libgeany.

Otherwise +1 for moving this function outside of TM - it doesn't belong there and I wanted to do this myself (but like Colomban I'd prefer having the implementation in utils).

;

#ifdef GEANY_PRIVATE

Expand Down