New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Improve documentation on duplication #1228
base: master
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3357,6 +3357,12 @@ Delete to line start Ctrl-Shift-BackSpace Deletes from the begin | |
current caret position. | ||
|
||
Duplicate line or selection Ctrl-D Duplicates the current line or selection. | ||
If the selection spans more than one line, | ||
this duplicates the lines containing selections. | ||
If the selection spans only a single line, then | ||
only the selection is duplicated. | ||
If nothing is selected, then the current line | ||
is duplicated. | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, but I'm not sure, seems to be even more confusing to me. Why talk about the selection being multiple lines? If its the selection, its the selection. I am not sure whats confusing about the existing description, but suggest "Duplicate the selection. If no selection duplicate the current line." if further clarification is needed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @elextr the point here is to say that if e.g. one and a half lines are selected, they will be both duplicated entirely, instead of duplicating one and a half line. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, ok, "Duplicate whole lines, either all lines wholly or partly in the selection, or the current line if no selection." There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @elextr nice try, but not quite that :) If a portion of a single line is selected, it only duplicates that portion (e.g. if you select Basically this tries to "do the right thing":
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dunno, sounds more confusing than the "right thing", but anyway as you can tell I don't use it :) Then a list just like your three dot points then, simple is better :) The only thing would be that the middle point might say "if the selection is on one line only, only the selection is duplicated" |
||
Transpose current line Transposes the current line with the previous one. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested to @b4n, "spans" is not the right word when its only part of a line.