Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Improve documentation on duplication #1228

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Improve documentation on duplication #1228

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b7ede9
Fix: Improve documentation on duplication
mgruben Sep 11, 2016
940aca3
Include third duplication scenario
mgruben Sep 12, 2016
c44de78
Rephrase description of duplication scenarios
mgruben Sep 12, 2016
ef061e9
Remove needless word
mgruben Sep 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/geany.txt
View file
Open in desktop
Expand Up @@ -3360,11 +3360,11 @@ Duplicate line or selection Ctrl-D Duplicates the current
If nothing is selected, this duplicates the
current line.
If the selection spans more than one line, this
duplicates the whole block of lines on which the
duplicates the whole block of lines which the
selection spans.
If the selection is a portion of a single line,
this duplicates the selected portion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I'm not sure, seems to be even more confusing to me. Why talk about the selection being multiple lines? If its the selection, its the selection.

I am not sure whats confusing about the existing description, but suggest "Duplicate the selection. If no selection duplicate the current line." if further clarification is needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elextr the point here is to say that if e.g. one and a half lines are selected, they will be both duplicated entirely, instead of duplicating one and a half line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok, "Duplicate whole lines, either all lines wholly or partly in the selection, or the current line if no selection."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elextr nice try, but not quite that :) If a portion of a single line is selected, it only duplicates that portion (e.g. if you select second in select the second word and duplicate, it gives you select the secondsecond word).

Basically this tries to "do the right thing":

  • if you have nothing selected, it duplicates the current line
  • if the selection spans a single line, it duplicates that portion
  • if the selection spans more than one line, it duplicates the whole block of lines on which the selection spans (e.g. extends the selection to span whole lines, and duplicates that portion)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno, sounds more confusing than the "right thing", but anyway as you can tell I don't use it :)

Then a list just like your three dot points then, simple is better :) The only thing would be that the middle point might say "if the selection is on one line only, only the selection is duplicated"

Transpose current line Transposes the current line with the previous one.

Scroll to current line Ctrl-Shift-L Scrolls the current line into the centre of the
Expand Down