Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themable compiler output in message window (GTK version) #1381

Closed
wants to merge 4 commits into from
Closed

Themable compiler output in message window (GTK version) #1381

wants to merge 4 commits into from

Conversation

Rakksor
Copy link

@Rakksor Rakksor commented Jan 27, 2017

A version of pull request #1377 that uses the GTK theme instead of the geany colorschemes to customize the colors of the compiler output in the message window.

@elextr
Copy link
Member

elextr commented Jan 27, 2017

Its great that you thought to do the docs, but you forgot to change them to the GTK way 😄

@Rakksor
Copy link
Author

Rakksor commented Jan 27, 2017

Damn, missed that. 😊
I just removed it for now without documenting the new stuff, since styling the tabs etc. isn't documented either.

@codebrainz
Copy link
Member

@Rakksor nice work. I will try to test and merge this weekend if I get time.

We should probably squash the (now) unrelated commits so we just get the changes in 33a8cc9. @Rakksor if you want to do it ahead of time, it will make merging it a little easier.

@elextr
Copy link
Member

elextr commented Jan 28, 2017

Works for me, not depending on the theme colours is the way to go.

@codebrainz do not merge this until the documentation is done, which as @Rakksor said depends on #1380 but as discussed on IRC @b4n is gonna look at that soon :)

[Edit: to be clear, #1380 should add a section to the manual documenting the tab names, and then these names just get added to that section]

Also @b4n should probably approve GTK fixes :)

@codebrainz
Copy link
Member

See #1382

@codebrainz codebrainz mentioned this pull request Jan 28, 2017
@Rakksor Rakksor closed this Jan 30, 2017
@Rakksor
Copy link
Author

Rakksor commented Jan 30, 2017

Closed since this has been included in #1382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants