Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search marker translucency (currently ignoring scheme) #1490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix search marker translucency (currently ignoring scheme) #1490

wants to merge 1 commit into from

Commits on May 3, 2017

  1. Fix search marker translucency (currently ignoring scheme) 

    On filetypes common it says: "# translucency for the line marker(first argument) and the search marker (second argument)
marker_translucency=255;255"
However changing the 2nd argument does NOT affect search marker translucency.
The proposed change addresses this.

On the downside: current hard-coded value of 60 (very transparent) would become filetypes.common's default of 255 (no transparency).

On the upside:
1) we would be consistent with what is indicated in filetypes.common about translucency for the search marker
2) this change may help all DARK themes, since marked words are barely visible no matter the GCS_MARKER_SEARCH background color used. By changing the translucency we can make them standout, just like in white themes.
    @Galland
    Galland committed May 3, 2017
    Configuration menu
    Copy the full SHA
    4776cd4 View commit details
    Browse the repository at this point in the history