Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel 'MSG_TYPE_RESAVE' info bar if still open in function 'document_reload_force'. #1621

Closed
wants to merge 1 commit into from

Conversation

lpaulsen93
Copy link
Contributor

Fixes #1330.

@codebrainz
Copy link
Member

Will try to test soon. Requested review from @kugel- since he worked on this code a lot.

Copy link
Member

@kugel- kugel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGBI. The change makes sense since after reload the buffer and on-disk file are in sync.

Just the commit message could be improved.

@lpaulsen93
Copy link
Contributor Author

To what? Take the title from issue 1330?

@elextr
Copy link
Member

elextr commented Oct 5, 2017

@LarsGit223 Git takes the first line of the commit description as the title of the commit, so it should be a short but complete one line summary. Full details then go on the following lines which are taken as the body of the commit message. Don't continue the title line into the message body.

@lpaulsen93
Copy link
Contributor Author

I created a new PR with a different commit message, see #1628. So this can be closed.

@lpaulsen93 lpaulsen93 closed this Oct 5, 2017
@codebrainz
Copy link
Member

codebrainz commented Oct 5, 2017

@LarsGit223 you can also do a "force push" to your existing branch to reword it, something like these steps:

$ git checkout issue1330
$ git commit --amend # and then reword the message
$ git push <your-remote-here> +issue1330

This will also update the associated PR.

@lpaulsen93
Copy link
Contributor Author

Ahh...thanks. The info that I had was that git commit --amend could only be used if the change was not pushed yet. So that info seems to be wrong.

@elextr
Copy link
Member

elextr commented Oct 6, 2017

@LarsGit223 its correct that you should not force push changes to public repositories that lots of people will pull from, but for a pull request in its own branch its fairly safe.

@lpaulsen93 lpaulsen93 deleted the issue1330 branch November 22, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants