tagmanager: do not rewind file on '# format=ctags' #1816
Conversation
On import of a global tags file, do not rewind the file if the first line is '# format=ctags'. Otherwise the import would abort on the first line and 0 symbols would be imported. Fixes geany#1814.
|
No, that won't work. Simply not rewinding will leave the file having read BUFSIZ which is guaranteed to be at least 256, so well past the end of the type spec that is to be skipped. So have to always rewind, then forward over the Or I'm not sure why it doesn't use getline() instead of reading BUFSIZ, but anyway. Also noticed the "skip" code here would seem to actually be an infinite loop? [Edit: So when its fixed, maybe it can be changed to skip |
|
No,
A problem would only occur if the line is longer than ``BUFSIZ```. |
Ok. |
This prevents loading a spurious tag for the format specifier line, as well as fixing loading of CTags format with a format specifier line. Before this change, the file pointer was rewound after reading a format specifier line; but this had various unwanted side effects depending on the recognized format: * For TagManager and Pipe formats, it led to loading a tag named after the format specifier (e.g. a literal "# format=tagmanager"). This was fairly harmless and only introduced a spurious tag seldom even used because "#" isn't usually considered for looking up completions. * For CTags format, having an explicit specifier led to failure to load the file in most cases because the specifier line would be parsed but doesn't usually follow the format's requirements, leading to early abortion loading that file. On some very specific specifier lines actually following CTags format, it could have led to loading a spurious tag instead. Fixes geany#1814 and closes geany#1816.
|
While this seems to be a fair enough fix for the problem you describe, there's actually more issues with this |
|
Ok, closing this. |
On import of a global tags file, do not rewind the file if the first line is
# format=ctags. Otherwise the import would abort on the first line and 0 symbols would be imported. Fixes #1814.