Fix modifier for creating rectangular selections on Windows

[b4n]

33dafac restored the pre-Scintilla 3.10 default on non-Windows, but also changed the Windows one. Fix this so the modifier keeps its historical value on Windows as well.

[b4n]

@elextr @eht16 @codebrainz this might be candidate for… a 1.34.1! What do you think?

[elextr]

Just out of interest, since the variable isn't used anywhere else, why not use the #ifs to select between a pair of SSM calls and drop the variable?

But the idea looks ok, can't test on windows of course :)

this might be candidate for… a 1.34.1! What do you think?

Sure, plus #2027, @b4n, maybe you want to look at that.

[eht16]

Ok with me if you want to have a new release.

About the change: I'll try to test it on Windows tomorrow.

But I'm wondering if we really should keep the historical value of use the chance and unify the modifier on all platforms (including a documentation update).
Sure, this will hurt a few people who have to change their habits but in the long term it might be better and less confusing.

[b4n]

About the change: I'll try to test it on Windows tomorrow.

Thanks!

But I'm wondering if we really should keep the historical value of use the chance and unify the modifier on all platforms (including a documentation update).
Sure, this will hurt a few people who have to change their habits but in the long term it might be better and less confusing.

Well, Scintilla decided to do that the other way around (with Alt, the default on Windows), and we didn't like it on Linux because we still consider that it's used by a lot of WMs. I'm not sure doing the same the other way around makes much sense.
I agree that it'd be better to have a unified value, but it seems people don't agree with what is the Right One.

I guess I'd rather introduce a setting allowing to select whichever modifier people like best, and keep the historical defaults for existing users.

[codebrainz]

IMO, it's not a bad thing to make things more "native" per platform, if the cost is not high. I think having a setting makes the most sense (all keybindings would ideally be customizable), if anyone is willing to implement it.

[eht16]

Yes, let's keep it this way: Alt as default on Windows and Ctrl for the rest.

Tested the changes on Windows and works as expected when using the mouse to start a selection.
However, when using the keyboard, Scintilla seems to use Shift-Alt in any case, even if we set the modifier to Ctrl. I assume this is hardcoded somewhere or something.
After a quick look in the Scintilla documentation, I didn't find any other related setting to change the modifier for keyboard based selection. So this encourages even more the idea to keep Alt on Windows, as then mouse and keyboard modifiers are the same.

[b4n]

Just out of interest, since the variable isn't used anywhere else, why not use the #ifs to select between a pair of SSM calls and drop the variable?

The idea was just preventing duplicating the call. I don't mind much either way, but that's how I'd write it right now :)