Fix: winsize/sidebarpos restored incorrectly #2195
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigated the following bugs related to msgwin/sidebar/wingeom setup:
The former is because
gtk_widget_get_allocated_width(pane)
get '1' at startup.src/ui_utils.c: void ui_swap_sidebar_pos(void):
gtk_paned_set_position(GTK_PANED(pane), gtk_widget_get_allocated_width(pane) - gtk_paned_get_position(GTK_PANED(pane)));
The later is because sidebar position's setup is prior to msgwin's setup. If msgwin is too wide, sidebar's position will get inside the msgwin.
Test with:
Ubuntu 16.04,
Geany 1.36 (1046ea4) ---- with configuration (msgwin bottom/right, sidebar left/right, (un)save winpos/size),
GTK 3.18.9.