Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlighting: added API call to query GeanyLexerStyle by name #2336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpaulsen93
Copy link
Contributor

This PR adds a new API call to highlighting.c:

const GeanyLexerStyle *highlighting_get_named_style(const gchar *named_style);

This shall enable plugins to query styles dedicated to plugin specific highlighting. Plugins could have their own styles with dedicated keys/names and instruct users to simply add them to a colorscheme. Another option would be a configuration setting in a plugin but then the setting is separated from the colorscheme which may result in bad readability.

Also see the discussion at #2331.

Copy link
Member

@elextr elextr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use-case makes sense now that its explained clearly.

src/highlighting.c Outdated Show resolved Hide resolved
@codebrainz
Copy link
Member

To be honest I dislike the idea of exposing anything colour scheme related to plugins as the current system is rather a mess due to how it evolved, and I'd very much like to be able to overhaul it - something I started some time ago, and will eventually continue with - without regard for breaking plugins (in addition to user schemes).

That said, I don't want to block progress for something that will not happen any time soon, so whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants