New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3 More Keybindings #2536
base: master
Are you sure you want to change the base?
Added 3 More Keybindings #2536
Conversation
Added 3 more keybindings for "Send Selection To"
Added 3 more keybindings for "Send Selection To"
Added 3 more keybindings for "Send Selection To"
@elextr , awesome. Thanks! That was it. |
Are there any problems with this pull-request that is preventing it from being merged? |
@@ -275,6 +275,9 @@ enum GeanyKeyBindingID | |||
GEANY_KEYS_EDITOR_DELETELINETOBEGINNING, /**< Keybinding. */ | |||
GEANY_KEYS_DOCUMENT_STRIPTRAILINGSPACES, /**< Keybinding. | |||
* @since 1.34 (API 238) */ | |||
GEANY_KEYS_FORMAT_SENDTOCMD10, /**< Keybinding. */ | |||
GEANY_KEYS_FORMAT_SENDTOCMD11, /**< Keybinding. */ | |||
GEANY_KEYS_FORMAT_SENDTOCMD12, /**< Keybinding. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have added these at the end, good, but they are in the plugin API but you havn't increased the API number, and then you can add it to the comments like the previous line.
One comment, otherwise looks ok, but I don't have time to test it, if you can get someone who is not you to test it and post it works that would help. |
Do you actually continously use more than ten commands with 'Send Selection To'? Otherwise we might end up with 20 or more keybindings for this in the end... |
Incremented `GEANY_API_VERSION` in plugindata.h
Added 3 more keybindings for "Send Selection To".
I am obviously missing something. The keybindings are recognized (i.e. I can add more "Sent Selection To" commands and the keybinding will be shown in the menus of "Edit→Format→Send Selection to") and I can run the commands by manually going to "Edit→Format→Send Selection to" and clicking the desired command. However, pressing the keyboard shortcut for these new "Edit→Format→Send Selection to" commands will not run the assigned commands. Perhaps, somebody can point me in the correct direction.