Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3 More Keybindings #2536

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

DevynCJohnson
Copy link
Contributor

Added 3 more keybindings for "Send Selection To".

I am obviously missing something. The keybindings are recognized (i.e. I can add more "Sent Selection To" commands and the keybinding will be shown in the menus of "Edit→Format→Send Selection to") and I can run the commands by manually going to "Edit→Format→Send Selection to" and clicking the desired command. However, pressing the keyboard shortcut for these new "Edit→Format→Send Selection to" commands will not run the assigned commands. Perhaps, somebody can point me in the correct direction.

Added 3 more keybindings for "Send Selection To"
Added 3 more keybindings for "Send Selection To"
Added 3 more keybindings for "Send Selection To"
@elextr
Copy link
Member

elextr commented Jun 27, 2020

Hint

@DevynCJohnson
Copy link
Contributor Author

@elextr , awesome. Thanks! That was it.

@DevynCJohnson
Copy link
Contributor Author

Are there any problems with this pull-request that is preventing it from being merged?

@@ -275,6 +275,9 @@ enum GeanyKeyBindingID
GEANY_KEYS_EDITOR_DELETELINETOBEGINNING, /**< Keybinding. */
GEANY_KEYS_DOCUMENT_STRIPTRAILINGSPACES, /**< Keybinding.
* @since 1.34 (API 238) */
GEANY_KEYS_FORMAT_SENDTOCMD10, /**< Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD11, /**< Keybinding. */
GEANY_KEYS_FORMAT_SENDTOCMD12, /**< Keybinding. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added these at the end, good, but they are in the plugin API but you havn't increased the API number, and then you can add it to the comments like the previous line.

@elextr
Copy link
Member

elextr commented Jun 10, 2021

One comment, otherwise looks ok, but I don't have time to test it, if you can get someone who is not you to test it and post it works that would help.

@eht16
Copy link
Member

eht16 commented Jun 12, 2021

Do you actually continously use more than ten commands with 'Send Selection To'?
I'm wondering if this is really necessary or if maybe the "Commander" plugin (https://plugins.geany.org/commander.html) could be an alternative.

Otherwise we might end up with 20 or more keybindings for this in the end...

Incremented `GEANY_API_VERSION` in plugindata.h
@DevynCJohnson
Copy link
Contributor Author

@elextr , I incremented GEANY_API_VERSION as per your suggestion.

@eht16 , yes, I use that many keybindings and commands for "Send Selection To". True, I could use Commander. However, I prefer to keep often used actions very quickly and easily accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants