Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Make TCP socket port number configurable #2585

Merged
merged 3 commits into from Sep 26, 2020
Merged

Windows: Make TCP socket port number configurable #2585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a57b9a
Windows: Make TCP socket port number configurable
eht16 Sep 12, 2020
64864cb
Validate port number before using it
eht16 Sep 13, 2020
d44b61f
Allow TCP ports from 1024 to 65535 and document it
eht16 Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/geany.txt
View file
Open in desktop
Expand Up @@ -2678,7 +2678,8 @@ number_exec_menu_items The maximum number of menu items in the 2
socket_remote_cmd_port TCP port number to be used for inter 2 on restart
process communication (i.e. with other
Geany instances, e.g. "Open with Geany").
Only available on Windows.
Only available on Windows, valid port
range: 1024 to 65535.
================================ =========================================== ========== ===========

Statusbar Templates
Expand Down
2 changes: 1 addition & 1 deletion src/libmain.c
View file
Open in desktop
Expand Up @@ -417,7 +417,7 @@ static gint get_windows_socket_port(void)
geany_debug("Using TCP port number %d for IPC", port_number);
g_free(configfile);
g_key_file_free(config);
codebrainz marked this conversation as resolved.
Show resolved Hide resolved
g_return_val_if_fail(port_number >= 1 && port_number <= (gint)G_MAXUINT16,
g_return_val_if_fail(port_number >= 1024 && port_number <= (gint)G_MAXUINT16,
SOCKET_WINDOWS_REMOTE_CMD_PORT);
return port_number;
}
Expand Down