Make GTK3 build the default, and GTK2 build optional #2610
Conversation
|
I don't know why the Mingw CI build is not getting the |
|
@codebrainz its configured GTK 3.8.2 which is pretty olde, is that the problem? |
There was a problem hiding this comment.
GTK 3.8.2 is not the problem as we use it on all other Travis builds as well and they work fine.
I was able to reproduce this error with a ubuntu:trusty Docker container after replicating the steps the Travis build does. Though I don't see the cause for the error. My best guess is that any of the changes in configure.ac breaks the linking.
EDIT: found the cause for the linking errors, see #2610 (comment).
|
Should be all good now. Let me know if/when I should merge it or if there's anything else. |
|
LGBCI (Cursory) |
|
Looks fine now and even works :). Fine to me to merge. |
* Replace `--enable-gtk3` with `--enable-gtk2` * Update Travis CI builds * Change `cross-build-mingw.sh` default to GTK3 and cleanup a little After this commit it will be required to pass `--enable-gtk2` to the Autoconf script in order to build with GTK+2, otherwise GTK+3 will be required.
codebrainz
force-pushed
the
gtk2-optional
branch
from
937001c
to
6095bc1
Compare
|
Rebased on Will merge once CI completes. |
As discussed in #2602, make GTK+3 the default of the build system, leading up to the eventual removal of GTK+2 support.
The
--enable-gtk3configuration option is replaced with--enable-gtk2. If--enable-gtk2is specified, the GTK+2 development libraries/headers must be available viapkg-configor else configuration will fail. If--enable-gtk2is not specified, the GTK+3 development libraries/headers must be available or else configuration will fail. It intentionally does not fall back to GTK+2 automatically.