Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Drop GTK2 support #2617

Closed
wants to merge 3 commits into from
Closed

WIP: Drop GTK2 support #2617

wants to merge 3 commits into from

Conversation

b4n
Copy link
Member

@b4n b4n commented Oct 10, 2020

No description provided.

@b4n b4n added this to the 1.38 milestone Oct 10, 2020
@b4n
Copy link
Member Author

b4n commented Oct 10, 2020

As we're talking about dropping GTK2, here's a shot at cleaning things up. I intentionally kept some of the infrastructure to support more than one version for when we'll start GTK4 support (even though I don't yet know how that would look like) so it's a little easier; but all GTK2-related stuff should be gone.

One noteworthy thing that isn't completely gone is gtkcompat.h header: I dropped all actual use from Geany itself, but for the moment I have been conservative on removing it from anywhere plugins could be reaching it from.

@b4n
Copy link
Member Author

b4n commented Oct 10, 2020

BTW, feel free to take over if/when needed, as I am famous for lack of time lately 😉

@codebrainz
Copy link
Member

BTW, feel free to take over if/when needed, as I am famous for lack of time lately

If you lack time, then why spend all that time completely re-creating #2602 instead of just requesting or pushing changes to it?

@b4n
Copy link
Member Author

b4n commented Oct 10, 2020

@codebrainz Oops. Probably because I didn't see it, and didn't think about looking for it even -- which is stupid on my part. Well, so I'll try and see if there's anything worth in here for yours.

@b4n b4n closed this Oct 10, 2020
@codebrainz
Copy link
Member

@b4n the GDK keysyms stuff for sure, and making the CI work. I allowed commits by maintainers on that branch and I think you have push rights on my fork anyway, feel free to just push anything you think is useful.

@b4n b4n mentioned this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants