OS Info Improvements

[codebrainz]

Handles macOS and older GLibs better, as a follow-up for #2498.

Some tests so far:

• Apple macOS
  • OS: macOS
• Win7
  • OS: Windows 7 SP17Vista SP2Vista SP1VistaXP SP3XP SP2XP SP1XP (Unknown)
• Win10 w/ Msys2 (same output for 32 and 64-bit msys2):
  • OS: Windows 10 2004 (Unknown)
• Debian
  • OS: Debian GNU/Linux bullseye/sid
• Ubuntu 20.04
  • OS: Ubuntu 20.04.1 LTS (focal)
  • OS: Linux Mint 20 (ulyana)
• Ubuntu 20.04 with incompatible GLib
  • OS: Linux

If it gets enough testing, could make 1.37, else we can leave for next release.

[elextr]

WFM, result in list above.

[frlan]

Debian:

OS: Debian GNU/Linux bullseye/sid

[eht16]

Windows 7:
OS: Windows 7 SP17Vista SP2Vista SP1VistaXP SP3XP SP2XP SP1XP (Unknown)

[codebrainz]

Debian:

OS: Debian GNU/Linux bullseye/sid

Is the "bullseye/sid" part parenthesized or exactly as above?

[frlan]

As in the quote

[elextr]

Well with the weird Debian naming scheme I guess it doesn't have a per version nickname like fossa for Ubuntu, so having no nickname makes (twisted Debian) sense. Anyway it provides information on the OS which is the main thing.

[elextr]

Also making the strings untranslated makes it mergable now we are in string freeze :)

[eht16]

Just for completeness:
OS: Arch Linux

[techee]

I get

16:13:53: Geany INFO		: OS: macOS

Question: the function is exported as an API function to plugins. Is this something plugins are actually interested in?

[frlan]

@elextr Bullseye is actually name of the next major one -- Running testing here

@codebrainz Just compiled your branch with nix package manager -- still describing itself as Debian:

Geany-INFO: 20:16:45.424: Geany 1.37, C
Geany-INFO: 20:16:45.424: GTK 3.24.21, GLib 2.64.5
Geany-INFO: 20:16:45.426: OS: Debian GNU/Linux bullseye/sid
Geany-INFO: 20:16:45.426: System data dir: /nix/store/cyk52jflc1v4aj5pqry8v57sv9p1ha9h-geany-1.37git/share/geany
…

But I guess this is about g_get_os_inf() ist working.

[elextr]

@techee AFAICT its not actually in the API, the documentation message is not a doxygen comment and the function isn't marked GEANY_API_SYMBOL.

In theory a plugin might use the info, but given the variability (and as @frlan showed the fact that derived distros may show as the base distro) its probably not much use to a plugin.

[elextr]

@frlan the g_get_os_info() docs say "On Linux this comes from the /etc/os-release file." so if your distro is derived from Debian its probably not modifying that file. So as much as I like to blame G* for everything, in this case its probably not their fault.

[b4n]

@techee AFAICT its not actually in the API, the documentation message is not a doxygen comment and the function isn't marked GEANY_API_SYMBOL.

No, but it has an API version in the @since tag, which doesn't make much sense.

In theory a plugin might use the info, but given the variability (and as @frlan showed the fact that derived distros may show as the base distro) its probably not much use to a plugin.

Also, I don't see why a plugin would need that info if it's not an actual mean of identifying the platform (and even then, it's probably not a good metric to do anything). As is it's really meant as a human-readable clue rather than something formal. So ATM I don't see any reason for it to make it to plugin API anytime soon.

[codebrainz]

No, but it has an API version in the @since tag, which doesn't make much sense.

I just put that so it was easy to see when it was added, but agree the (API 239) part doesn't make a whole lot of sense.

[elextr]

@SInCE sorry @codebrainz didn't mean to ping you, he just forgot to quote some Doxygen syntax.

[codebrainz]

Updated according the comments, squashed, rebased, and force pushed.

[elextr]

LGBI now

[codebrainz]

Should we merge this last minute, or wait till next release? I don't mind either way, it's not like it's a critical enhancement.

[eht16]

I'd like to have it merged. It will help users to help us when handling bug reports and the change is pretty harmless.