Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not convert filename when opening files from command line on Windows #2660

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Nov 15, 2020

  1. Do not convert filename when opening files from command line on Windows

    It's unclear why the previous was added (by me) 12 years ago.
    Maybe the code in main_handle_filename() or after has been
    changed/improved so that it works now or the previous test case for
    opening files from the command line was wrong.
    This happens only when starting a new instance of Geany from command
    line. Opening files in a running instance works fine with and without
    this change.
    
    Closes geany#2652.
    eht16 committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    efed718 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Configuration menu
    Copy the full SHA
    30706ad View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. Convert working directory from UTF-8 to locale on Windows

    When passing filenames from the command line on Windows, the filename
    is in system locale. If it is a relative path, we make it absolute with
    the current working directory which is in UTF-8 encoding.
    So we need to convert the current working directory also to system
    locale, join the filename and then convert both back to UTF-8.
    
    Closes geany#2652.
    eht16 committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    3fd5763 View commit details
    Browse the repository at this point in the history