New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use relative path in project file #2667
base: master
Are you sure you want to change the base?
Conversation
Some bug were detected... |
Travis failed because I close the pull request during the check, and now that it is re-opened, I can launch it again. |
Here you go. |
Ok, my bad, I didn't read the doc in detail, I use g_canonicalize_filename, which is for glib 2.58 or above. I will try again ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not reviewed in detail yet.
This capability needs to be documented in the manual, including downsides and risks such as accidentally storing all files you have open in git and broadcasting that to the world. New settings not documented either.
I have push a new commit taking into account your remarks (Was it the good way to proceed ?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find a better way...
Can I do something to help the integration of this pull request? Regards |
I don't think its this PR, but it would be nice if the CI passed. But I don't have a clue what its problem is, maybe somebody who understands travis can look at it. |
I had a look to the CI. E: Failed to fetch http://apt.postgresql.org/pub/repos/apt/dists/ trusty-pgdg /main/binary-i386/Packages While building the environment, it try to install package from this repo.Trusty is a reference to an Ubuntu version of 2014, end of life 2019. Now postgresql is not delivering this package any more, we can see that here : http://apt.postgresql.org/pub/repos/apt/dists/ Since this PR was a bit old, I rebase it onto master. Now I got these 57 commits in the PR, half of these are already in master. I don't have a clue of how I should have done. |
@Keuronde ok, makes sense. According to https://wiki.ubuntu.com/Releases Xenial has also reached end of standard support (last month). I'll try changing Also I think you need to rebase, 210 changed files won't get reviewed but hopefully most are not actually changed by you. |
--------> test case : close project NOK
On lit la propriété du fichier session et on active la case à cochée correspondante
La case est lue et le fichier seesion est mis à jour
Ok seems that the CI is up again with Bionic, could my PR have a try ? |
6286d46
to
209dd74
Compare
This pull request allow the usage of relative filepath in the Project file (.geany) and add a checkbox in the project config to active this option.
The aim is to be able to duplicate a project with a copy-paste or to save a project file (.geany) in git, svn or whatever.
issue #2483