Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write absolute path to geany bin in desktop file #2728

Closed
wants to merge 8 commits into from
3 changes: 1 addition & 2 deletions configure.ac
Expand Up @@ -9,9 +9,8 @@ AC_CONFIG_MACRO_DIR([m4])
AM_INIT_AUTOMAKE([1.11 -Wall parallel-tests subdir-objects])
AC_CONFIG_HEADERS([config.h])

PKG_DESC="A fast and lightweight IDE"
PKG_DESC="A fast and lightweight IDE using GTK+"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's kind of over-engineering the thing, and IMO should at least not be part of this change.

AC_SUBST([PKG_DESC])
AC_DEFINE_UNQUOTED([PKG_DESC], [_("$PKG_DESC")], [use PKG_DESC as defined in configure.ac])

m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])])

Expand Down
1 change: 0 additions & 1 deletion po/POTFILES.in.in
@@ -1,7 +1,6 @@
# List of source files containing translatable strings.

@top_builddir@/geany.desktop.in
@top_builddir@/config.h
data/geany.glade
src/about.c
src/build.c
Expand Down
2 changes: 1 addition & 1 deletion src/about.c
Expand Up @@ -213,7 +213,7 @@ static GtkWidget *create_dialog(void)
gtk_label_set_justify(GTK_LABEL(label_info), GTK_JUSTIFY_CENTER);
gtk_label_set_selectable(GTK_LABEL(label_info), TRUE);
gtk_label_set_use_markup(GTK_LABEL(label_info), TRUE);
g_snprintf(buffer, sizeof(buffer), INFO, PKG_DESC);
g_snprintf(buffer, sizeof(buffer), INFO, _("A fast and lightweight IDE"));
gtk_label_set_markup(GTK_LABEL(label_info), buffer);
gtk_misc_set_padding(GTK_MISC(label_info), 2, 11);
gtk_widget_show(label_info);
Expand Down
2 changes: 1 addition & 1 deletion src/libmain.c
Expand Up @@ -554,7 +554,7 @@ static void parse_command_line_options(gint *argc, gchar ***argv)

context = g_option_context_new(_("[FILES...]"));

g_option_context_set_summary(context, PKG_DESC);
g_option_context_set_summary(context, _("A fast and lightweight IDE."));
g_option_context_set_description(context, _("Report bugs to https://github.com/geany/geany/issues."));
g_option_context_add_main_entries(context, entries, GETTEXT_PACKAGE);
g_option_group_set_translation_domain(g_option_context_get_main_group(context), GETTEXT_PACKAGE);
Expand Down