Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ctags to version p5.9.20210411.0 #2830

Closed
wants to merge 1 commit into from

Conversation

dolik-rce
Copy link
Contributor

Update the ctags to minimal version required for the Kotlin parser to work. No changes to the geany sources were necessary.

This a prerequisite to dolik-rce#1, as suggested by @elextr in #2778 (comment). Unfortunately, that PR can't be created here directly, since it compares two branches in my fork, but I will move it to this repository as soon as this PR is accepted or when someone with commit rights to geany repository pulls in this branch.

@elextr
Copy link
Member

elextr commented Jun 21, 2021

Unfortunately, that PR can't be created here directly

As much as we love to complain about Github, in this case I think its Linus' fault because Git doesn't have the capability of making a patch that depends on another until the first is merged.

@elextr elextr mentioned this pull request Jun 24, 2021
10 tasks
@elextr
Copy link
Member

elextr commented Aug 9, 2021

@dolik-rce just to let you know this isn't forgotten, but we are trying to update the windows build architecture for GTK3 and then get a team together to make a 1.38 release. This will be merged as soon after that so it has time to be tested before the next release, but its better not to do it just before.

@dolik-rce
Copy link
Contributor Author

Ok, I'll wait. I very much appreciate the update, thank you.

@techee
Copy link
Member

techee commented Sep 2, 2021

Not sure how we are going to handle ctags updates in Geany - I'd suggest always updating to the latest ctags version after making a release and then, if possible, not touching it until the next release so it gets sufficient testing. If we do it this way, this pull request might be replaced by a newer ctags release (should be no problem, I can do it myself).

@elextr
Copy link
Member

elextr commented Sep 2, 2021

@techee yeah, that was the plan

[Edit: just to be clear, I don't mean that you should do it, though of course you are welcome, I mean that it should be done soon after each release]

@dolik-rce
Copy link
Contributor Author

@elextr: Now that 1.38 was released, is it the right time to update ctags? Should I create new PR to update to newest version?

@elextr
Copy link
Member

elextr commented Nov 5, 2021

@dolik-rce not forgotten, this was the next thing I planned to test after Scintilla 5 updates if nobody beat me to it. Due to Scintilla being central to Geany and this update being a jump of two major versions of Scintilla it is important to do first to allow maximum testing. Unfortunately there have been a couple of bugs in Scintilla which are addressed in 5.1.4 due out "in a couple of days" and should allow that to be merged.

Of course that doesn't stop anyone else from looking at this and/or updating to the latest ctags as discussed above.

@techee
Copy link
Member

techee commented Nov 5, 2021

Of course that doesn't stop anyone else from looking at this and/or updating to the latest ctags as discussed above.

Yeah, I was actually thinking about doing it myself (against the latest version of ctags) in case some problems pop up as I probably have most experience with this stuff. Will try to prepare a pull request today.

@dolik-rce
Copy link
Contributor Author

This has been superseded by #2984, closing.

@dolik-rce dolik-rce closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants