Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Send Selection to" from Edit/Format to Edit #2899

Closed
wants to merge 3 commits into from

Conversation

xiota
Copy link
Contributor

@xiota xiota commented Sep 18, 2021

I've been using Geany for years and never knew this feature exists. I saw it mentioned in a comment, but didn't find it. I did find "Send Selection to Terminal", but it was grayed out. So I thought maybe that was what I was looking for, but couldn't use it for whatever reason. (I thought this might be like the plugins that no longer compile.) So I forgot about it. Then I saw this feature mentioned someplace else in a different context. So I went searching again, and still didn't find it. So I asked the internet, and finally found out where it is.

Two levels of nested menus seems like a bit too much. So this PR is to make the "Send Selection to" feature easier to find and use. It's renamed to "Send Selection" and moved from Edit/Format to Edit menu.

@elextr
Copy link
Member

elextr commented Sep 18, 2021

I've been using Geany for years and never knew this feature exists.

In the nicest possible way 😁 ... RTFineM.

Its below "Format" because the basic base use-case is formatting the selection as the Fine Manual says, passing a selection in and pasting the results in its place.

Even if the PR is accepted the manual needs to be updated to agree.

Which version of Glade did you use to make the changes?

@xiota
Copy link
Contributor Author

xiota commented Sep 18, 2021

The manual is where the internet searches eventually led. It's still a pain to have to go through nested menus to access the feature. Even though there are auto assigned shortcuts, users would still have to go through the menu to remind themselves of infrequently used commands.

I used Geany itself to edit the file because I didn't want Glade to mess with other portions of the file. I've updated the manual.

@elextr
Copy link
Member

elextr commented Sep 18, 2021

The problem with hand editing the file is that Glade is very picky and this might make the next change made with Glade have irrelevant changes as it adjusts your hand edits. Perhaps wait until after #2860 and then you can use a modern Glade instead of having to hand edit or compile Glade 3.8.5.

As for moving the menu, we don't want the top level menus getting too large, that prevents use on some small screen systems. But Edit isn't the longest menu, so I personally don't care if one more top level is added, but depends on what others think.

You will also have to sort out the mnemonics, s is already used in the top level edit menu.

@xiota
Copy link
Contributor Author

xiota commented Sep 18, 2021

I'm not in a hurry, since I already have it running this way on my machine. I just submitted the PR because nested menus aren't great for features users might actually want to use. They're fine for things like filetype and encoding that are supposed to be autodetected.

For the mnemonics, is preferences 'S' for settings? Is it so frequently accessed that it needs a mnemonic? I'm looking at other programs, and they each seem to use a different letter.

@elextr
Copy link
Member

elextr commented Sep 18, 2021

All menu items need a mnemonic, its how you drive it without a mouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants