New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to hide project close/save warning when opening new project #2949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the po/.intltool-merge-cache.lock
otherwise I'm ok. Good that its documented in the manual and in the plugin API.
But lets see if anyone else loves or loathes it.
Added to 1.39 milestone so its not forgotten |
Sorry about that lock file... is it okay if I add it to |
Shouldn't need to 2977a91 |
Tested and LGTM apart from the minor issue regarding bumping Maybe the PR description could be updated to not mention "Don't re-open a project that is already open" which isn't part of this PR anymore? |
@eht16 I've edited the initial description. I don't know how to bump the |
I think I would prefer |
@eht16 The original name I chose was pretty ridiculous: |
I just saw... #2863 ... warning dialog when the project file is read-only... Does adding an option to hide that warning get it's own PR, or can it be added to this one? If favor of combining in one PR:
|
I decided to rename the option to |
For me this is fine to merge (whith squashed commits). |
15bb0bf
to
ded9392
Compare
Force push to rebase and squash commits. |
🎉 🎊 🎉 🎊 🎉 🎊 |
This adds an option to hide the warning when opening a project while one is already open. (The default is to retain the warning.) Since projects autosave when closed, no work is lost and the project can just be reopened if needed. Depending on how the user manages project files, reopening the previous project can take less time than responding to the dialog.