Fix derefence of NULL pointer #2963
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since its tested a billion [exaggeration for effect] times a few more won't hurt. The pointer is/should be set to a valid value at document creation and all the tests removed, but since this is C not C++ the invariant can't be guaranteed against accidental/deliberate violation. [end rant, ducks missile from @b4n] 😄 In both cases I would have put the tests at the end of the block above which also tests for |
rootkea
force-pushed
the
dereference-NULL
branch
from
7d85056
to
be1d2f2
Compare
Found by: scan-build
rootkea
force-pushed
the
dereference-NULL
branch
from
be1d2f2
to
c6247aa
Compare
Sorry for the delay. Done now! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This fixes dereference of
ft(NULL pointer) down the code.Found by: scan-build