Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When "go to line" is out of bounds, go to beginning or end of document #2973

Merged
merged 9 commits into from
Nov 9, 2021
Merged

When "go to line" is out of bounds, go to beginning or end of document #2973

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9cd5a29
When "go to line" is out of bounds, go to beginning or end of document
xiota Oct 30, 2021
f035c1e
change bounds check
xiota Oct 30, 2021
8fc12dc
remove unnecessary initialization
xiota Oct 30, 2021
d00212d
add comments
xiota Oct 30, 2021
662ae7e
change offset to gboolean in editor_goto_line()
xiota Oct 31, 2021
aa32cfa
update function declaration
xiota Oct 31, 2021
1138722
use gint for line_count
xiota Oct 31, 2021
c2786f5
change comment, formatting
xiota Oct 31, 2021
e11bc7b
reduce code duplication
xiota Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/callbacks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,17 +921,10 @@ void on_go_to_line_activate(GtkMenuItem *menuitem, gpointer user_data)
_("Enter the line you want to go to:"), value);
if (result != NULL)
{
GeanyDocument *doc = document_get_current();
g_return_if_fail(doc != NULL);

gint line_no = atoi(result);
gboolean offset = (*result == '+' || *result == '-');
on_toolbutton_goto_entry_activate(NULL, result, NULL);

if (! editor_goto_line(doc->editor, line_no, offset))
utils_beep();
/* remember value for future calls */
g_snprintf(value, sizeof(value), "%s", result);

g_free(result);
}
}
Expand Down