Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nim filetype config #2988

Merged
merged 3 commits into from Dec 10, 2021
Merged

Update Nim filetype config #2988

merged 3 commits into from Dec 10, 2021

Conversation

ZoomRmc
Copy link
Contributor

@ZoomRmc ZoomRmc commented Nov 8, 2021

Keywords taken from official manual: https://nim-lang.org/docs/manual.html#lexical-analysis-identifiers-amp-keywords
Identifiers list expanded with:

  1. Some basic types from the System module which is always implicitly imported.

  2. Additional keywords (lent, spawn, parallel) from Nim experimental features.

Styling and build-menu settings taken from @HJarausch config in #2669

Fixes #2669

Keywords taken from official Manual.
Identifiers list expanded with:
1. Some basic types from the System module, which is always implicitly imported.
2. Additional keywords (`lent, spawn, parallel`) from Nim experimental features.

Styling and build-menu settings taken from @HJarausch config in geany#2669
@elextr
Copy link
Member

elextr commented Nov 8, 2021

Can a nim user test and comment?

@ire4ever1190
Copy link

Nim user here, new keywords/types seem to highlight correctly 👍

...which won't work until the Nim lexer from lexilla is added.
@ZoomRmc
Copy link
Contributor Author

ZoomRmc commented Nov 10, 2021

Current settings use Python lexer for Nim files, however Lexilla already has a lexer for Nim.
This requires an additional PR, but I don't know the process of incorporating scintilla/lexilla updates Geany uses, so, please, advice.

With Python lexer multiline comments (and, perhaps, something else) don't work.

@elextr
Copy link
Member

elextr commented Nov 11, 2021

Probably best to wait for the new Scintilla to be merged to Geany before adding Lexilla parsers.

@ZoomRmc
Copy link
Contributor Author

ZoomRmc commented Dec 10, 2021

@elextr what need to be done to move forward with this?

@elextr
Copy link
Member

elextr commented Dec 10, 2021

I guess since another Nimist has commented this can be merged.

As for adding Lexers or parsers, that needs somebody who is interested to make a PR.

@elextr elextr merged commit d031d6f into geany:master Dec 10, 2021
@b4n b4n added this to the 1.39/2.0 milestone Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nim configuration is broken
4 participants