Update to Scintilla 5.1.5 and Lexilla 5.1.4 #3046
Conversation
Scintilla: - SCI_GETTEXT, SCI_GETSELTEXT, and SCI_GETCURLINE behaviorial changes - Autocompletion on Wayland (see geany#3009) Lexilla: - New parsers: gdscript (see geany#3012) and asciidoc (see geany#2986) but not imported yet
SCI_GETTEXT second parameter, the buffer length, does not account for the NUL termination anymore. Therefore, take care to not tell Scintilla to overwrite the last byte reserved for NUL termination.
|
I believe there is going to be a little enumeration conflict with the GDScript additions that would need to be resolved, are we merging this first and amending that, or some other approach? |
|
If GDscript is part of upstream why is there a conflict since this comes from upstream? |
|
In the linked PR that has the full GDScript addition that I've created here on the Geany pull request queue, the enumerations in scintilla/lexilla/include/LexicalStyles.iface and scintilla/lexilla/include/SciLexer.h are slightly different because I set them to 134 when adding them in Geany, but the geany source doesn't have asciiidoc yet which is the one that takes enumeration 134 in upstream so part of the fixes I did when working upstream was changing it to 135. |
|
Well I suggest rebasing your PR after this is merged. |
|
I'll merge this in a week or so in absence of impeding feedback |
|
@kugel- IMO it can be merged now so the GDScript pull request can be made ready for merging to Geany. |
|
Havn't noticed any problems with running this PR in last couple of weeks although not heavily tested. |
Scintilla:
Lexilla: