Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos #3096

Merged
merged 1 commit into from Jan 23, 2022
Merged

Fixing typos #3096

merged 1 commit into from Jan 23, 2022

Conversation

deining
Copy link
Contributor

@deining deining commented Jan 11, 2022

No description provided.

@elextr
Copy link
Member

elextr commented Jan 11, 2022

@deining the following has nothing to do with your changes AFAICT, they look fine.

@eht16 you are the Rest expert IIRC, looking at the check log for, binreloc=no, build action, lines 556-560 which appear to be from building the PDF manual, what are they??

@eht16
Copy link
Member

eht16 commented Jan 13, 2022

The PR looks good to me, thanks @deining.

@eht16 you are the Rest expert IIRC,

Who said this? I don't think so :).

looking at the check log for, binreloc=no, build action, lines 556-560 which appear to be from building the PDF manual, what are they??

Not sure, I don't think I've seen those before. Just tested locally and there are no such messages (with Debian testing).
The corresponding lines in geany.txt (line 1631 and following) are prefixed with a pipe. According to https://bashtage.github.io/sphinx-material/rst-cheatsheet/rst-cheatsheet.html#blocks, this creates a line block to ensure each line will be rendered a separate line.

Maybe it is just a specific version of rst2pdf in the build action environment which outputs these messages.

@eht16
Copy link
Member

eht16 commented Jan 23, 2022

Just had a closer look at the line blocks: they render equally on HTML and PDF outputs and the intention was to have line breaks between the four lines.
And as said, in current versions of rst2pdf this output is not present, so I guess this was rather some debugging output or similar in former rst2pdf versions. I would keep it as is. Even if not, we should discuss this in its own issue.

@eht16 eht16 merged commit 25f6cb6 into geany:master Jan 23, 2022
@deining deining deleted the contrib branch January 23, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants