Use the upstream TCL parser #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TCL parser is split into three parts: tcl - for parsing pure tcl code tcloo - for parsing tcloo OO extension of tcl itcl - for parsing itcl OO extension of tcl TCLOO and ITCL parsers run the TCL parser as a subparser but it isn't possible to combine all three parsers at the same time. Since TCLOO is the "modern" (but 10 years old) OO extension, it seems to be a better choice for Geany (if needed, a new filetype could be introduced for ITCL). Since it's run as a subparser, we need to introduce also a subparser tag type mapping for TCL (types are mapped to the same values here because they don't conflict with the TCLOO types). Also, the new parser reports full scope information so take care of that. In addition, scope by the TCL parser is prefixed by :: which we need to strip because the TM doesn't expect scope in this format. Update the unit test based on several uctags unit tests to cover the tags we generate with this parser.
This was referenced Apr 12, 2022
kugel-
approved these changes
May 3, 2022
|
|
||
| public method method1 | ||
| protected method method2 | ||
| private method method3 |
There was a problem hiding this comment.
Not sure if it matters but the new tests don't include public/private methods, TclOO supports these according to https://wiki.tcl-lang.org/page/TclOO+Tutorial, but I don't know if it ctags handles it at all?
There was a problem hiding this comment.
The way I understand it from the link you provided, public methods start with lowercase, private methods start with uppercase. The generated tags don't seem to report these (it wasn't the case before either and we don't use this information in Geany for anything right now).
Thanks for having a look at this. |
|
Tests pass, symbols show, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TCL parser is split into three parts:
tcl - for parsing pure tcl code
tcloo - for parsing tcloo OO extension of tcl
itcl - for parsing itcl OO extension of tcl
TCLOO and ITCL parsers run the TCL parser as a subparser but it isn't
possible to combine all three parsers at the same time. Since TCLOO
is the "modern" (but 10 years old) OO extension, it seems to be a better
choice for Geany (if needed, a new filetype could be introduced for
ITCL).
Since it's run as a subparser, we need to introduce also a subparser
tag type mapping for TCL (types are mapped to the same values here
because they don't conflict with the TCLOO types).
Also, the new parser reports full scope information so take care of that.
In addition, scope by the TCL parser is prefixed by :: which we need
to strip because the TM doesn't expect scope in this format.
Update the unit test based on several uctags unit tests to cover the
tags we generate with this parser.