Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session.conf split follow-up: sidebar_page #3168

Merged
merged 1 commit into from Apr 24, 2022
Merged

Conversation

kugel-
Copy link
Member

@kugel- kugel- commented Apr 14, 2022

Move sidebar_page layout to session.conf

The current tab of the sidebar notebook is now considered "session-related",
and thus moved from geany.conf to session.conf.

To allow of "sidebar_page" to be loaded from session.conf, the
"documents_show_paths" key is moved to keyfile.c, otherwise it would
also become session-related (due to the StashGroup in sidebar.c being tied
to session.conf).

Suggested by #3007

Move sidebar_page layout to session.conf

The current tab of the sidebar notebook is now considered "session-related",
and thus moved from geany.conf to session.conf.

To allow of "sidebar_page" to be loaded from session.conf, the
"documents_show_paths" key is moved to keyfile.c, otherwise it would
also become session-related (due to the StashGroup in sidebar.c being tied
to session.conf).
@kugel- kugel- requested review from eht16 and elextr April 14, 2022 19:31
@kugel- kugel- added this to the 1.39/2.0 milestone Apr 24, 2022
@kugel-
Copy link
Member Author

kugel- commented Apr 24, 2022

No feedback yet, hmm, I'll probably merge this in a few days if it stays like that.

@elextr
Copy link
Member

elextr commented Apr 24, 2022

LGBI

@kugel- kugel- added this to In Progress in session split via automation Apr 24, 2022
@kugel- kugel- merged commit d84f146 into geany:master Apr 24, 2022
session split automation moved this from In Progress to Done Apr 24, 2022
@kugel- kugel- deleted the session_split branch April 24, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants