Remove native file and color dialogs on Windows #3219
Conversation
| @@ -63,7 +63,7 @@ typedef struct GeanyInterfacePrefs | |||
| gboolean msgwin_compiler_visible; /**< whether message window's compiler tab is visible */ | |||
| gboolean msgwin_messages_visible; /**< whether message window's messages tab is visible */ | |||
| gboolean msgwin_scribble_visible; /**< whether message window's scribble tab is visible */ | |||
| /** whether to use native Windows' dialogs (only used on Windows) */ | |||
| /** whether to use native Windows' dialogs - ignored and not used anymore */ | |||
There was a problem hiding this comment.
Since this field is part of the API (and ABI), we cannot easily remove it.
Is it enough to mark it as ignored in the comment or are there better ways to handle this?
There was a problem hiding this comment.
I would suspect that there are not many Windows specific plugins out there, so probably ok.
There was a problem hiding this comment.
Actually so long as it is still initialized to say "Windows dialogs not used" then its definitely ok, since its not lying :-)
There was a problem hiding this comment.
It's not initialized explicitly at all. But at least on my Debian Testing, the resulting value when Geany is running is FALSE.
Their implementation was buggy, use very old Windows APIs and require double implementation and maintenance efforts for us The GTK dialogs work well for all other users already, so they probably will also for Windows users. Closes geany#3209.
eht16
force-pushed
the
remove_native_windows_dialogs
branch
from
e0b8bff
to
f793f72
Compare
|
|
||
| if (app->project && !EMPTY(app->project->base_path)) |
There was a problem hiding this comment.
Why is adding this shortcut removed?
There was a problem hiding this comment.
Bah!! ignore comment, githubs annoying handling of changed indent confused me.
There was a problem hiding this comment.
Yeah, sorry. The diffs are bit hard to read because of indentation changes :(:
|
Just remembered that there was #2794 that was "fixed" by using native dialogs once after install? |
Yes. This PR is the most easiest solution to solve the one problem in #3209. I'm happy to close this PR unmerged if we could find anyone else volunteering to do the good way. |
If it wasn't that #3209 is a crash I'd say leave the windows dialogs until GTK4 forces them out, after all they have been used for a long time without issues. But since its a crash I'd say merge it, if any white knight rides in on their trusty steed I suspect the olde code would not be much help since the Windows dialog APIs have changed, but they can always choose to start with the commit before merge of after, their choice. Or perhaps someone will try https://docs.gtk.org/gtk3/class.FileChooserNative.html and see if it works better on windows/macos and flatpack (see docs). |
|
Interesting, didn't know about GtkFileChooserNative. This seems to be available in gtk4 as well. |
|
If nobody stops me, I would merge this in a week or so. |
This is a left-over from geany#3219 and should have been removed already. Fixes geany#3627.
Their implementation was buggy, use very old Windows APIs and require
double implementation and maintenance efforts for us
The GTK dialogs work well for all other users already, so they probably
will also for Windows users.
Closes #3209.