Add soft keywords to Python keyword list #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to me, the Python experts seem to be in agreement that this should be done so ok. Committ message should also mention "... and update to Python 3.10" since it also removed |
eht16
force-pushed
the
issue3263_python_keywords_match_case
branch
from
0ee4e70
to
f5f3b7a
Compare
Thanks, done. |
|
If there won't be objections, I'll merge this in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
_,caseandmatchto the Python keywords list._seems not very useful but also won't hurt I guess. It will be highlighted as keyword when used in something likemessage = _('Text to be translated'), while not completely technically correct in this case, it is OK IMO and not worth the efforts to remove this single keyword from the list in the update script.N.B.: the
scripts/update-python-identifiers.shscript now requires Python 3.10 which was released about one year ago and the script is only to be executed by developers.Closes #3263.
Before:
After:
