Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tab label length and window title length configurable #3365

Merged
merged 2 commits into from Jan 29, 2023

Conversation

00AR
Copy link
Contributor

@00AR 00AR commented Jan 4, 2023

Implements #3344
Added a GtkSpinButton in "Notebook tabs" in Interface preferences. This will take as input, number of characters that the user wants to display on the tab label.
For now, Maximum value that can be entered: 100000
Default value: 99999(as suggested by @elextr to be very big number)
Minimum value that can be entered: 3
The value is stored in the variable tab_label_len declared in GeanyInterfacePrefs struct. This value will be written in geany.conf when save_dialog_prefs of keyfile.c is executed.
The tab label will get updated dynamically on clicking the Apply/Ok button in the Preferences dialog.
Screenshot from 2023-01-04 11-34-19

@00AR 00AR changed the title preference option for display size preference option for file display size Jan 4, 2023
Copy link
Member

@eht16 eht16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the few comments, it looks very good.

By accident I found #2112 which would be solved by this as well.

Maybe you could add "closes #2112 and #3344" to the commit message and rephrase it a bit as "display size" might be confused with the size of the monitor. Maybe something like "Make tab label length configurable".

src/prefs.c Outdated Show resolved Hide resolved
src/ui_utils.h Show resolved Hide resolved
src/document.c Show resolved Hide resolved
data/geany.glade Outdated Show resolved Hide resolved
@00AR
Copy link
Contributor Author

00AR commented Jan 16, 2023

I missed this, does the documentation also needs to be updated?

@elextr
Copy link
Member

elextr commented Jan 16, 2023

does the documentation also needs to be updated?

Yes, just add the description in geany.txt where that dialog is described, @eht16 will add the dialog to his list of images to be updated before release ;-)

@00AR 00AR changed the title preference option for file display size Make tab label length and window title length configurable Jan 16, 2023
@00AR 00AR requested a review from eht16 January 16, 2023 17:13
@eht16
Copy link
Member

eht16 commented Jan 20, 2023

Thanks for the changes, @00AR.

LGTM. I will merge in a few days if there will be no objections.

@00AR
Copy link
Contributor Author

00AR commented Jan 21, 2023

LGTM. I will merge in a few days if there will be no objections.

Alright. Thanks!

@eht16 eht16 merged commit 4508f77 into geany:master Jan 29, 2023
@b4n b4n added this to the 1.39/2.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants