Don't insert * after new line in multi-line comment if previous line … #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't start with * Fixes geany#3386.
techee
reviewed
Feb 10, 2023
| if (style == SCE_D_COMMENTNESTED) | ||
| continuation = "+"; /* for nested comments in D */ | ||
|
|
||
| else if (!(g_str_has_prefix(previous_line + i, continuation) && |
There was a problem hiding this comment.
I'd just suggest inverting the condition (i.e. removing the initial !) and adding the 3 lines after this block inside the block. This way you avoid the duplicated g_free(previous_line); and the extra return.
There was a problem hiding this comment.
Apart from that the PR looks fine to me and is useful, I also did run into this issue in the past.
There was a problem hiding this comment.
That would break the first if clause before the else if on this line.
There was a problem hiding this comment.
Ah, right, sorry, I didn't think about that.
There was a problem hiding this comment.
No problem, thanks for reviewing.
elextr
reviewed
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…doesn't start with *
Fixes #3386.
Note: This was already the case when the previous line is blank, but a * was inserted when it is not blank.